Skip to content

Mini challenge 3 #46

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
AlanCantabrana wants to merge 6 commits into
base: master
Choose a base branch
from
Open

Mini challenge 3 #46

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
bd49425
first commit
Mar 20, 2021
bc2d1e0
Mini-Challenge 2
Mar 20, 2021
5d26987
Mini-Challenge 2
Mar 20, 2021
9a6f07f
Mini-Challenge 3
Apr 3, 2021
1e0bc31
Adding TestCoverage
Apr 3, 2021
08f07a1
adding realated videos
Apr 6, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .eslintrc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@
"plugins": ["prettier"],
"rules": {
"prettier/prettier": "error",
"react/jsx-filename-extension": "error",
"react/jsx-filename-extension": "off",
"react-hooks/exhaustive-deps": "warn",
"import/no-unresolved": ["off", { "ignore": [".css$"] }],
"import/prefer-default-export": "off",
Expand Down
56 changes: 56 additions & 0 deletions TestCoverage.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,56 @@
----------------------------|----------|----------|----------|----------|-------------------|
File | % Stmts | % Branch | % Funcs | % Lines | Uncovered Line #s |
----------------------------|----------|----------|----------|----------|-------------------|
All files | 89.09 | 80 | 92 | 89.81 | |
Copy link

@PacoMojica PacoMojica Apr 11, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome, the coverage percentage is high on all columns

src | 50 | 100 | 100 | 50 | |
index.js | 0 | 100 | 100 | 0 | 6 |
mockData.js | 100 | 100 | 100 | 100 | |
src/components | 0 | 0 | 0 | 0 | |
index.js | 0 | 0 | 0 | 0 | |
src/components/App | 75 | 100 | 60 | 75 | |
App.component.jsx | 75 | 100 | 60 | 75 | 26,27,28,45 |
index.js | 0 | 0 | 0 | 0 | |
src/components/Header | 100 | 100 | 100 | 100 | |
Header.jsx | 100 | 100 | 100 | 100 | |
Header.styled.js | 100 | 100 | 100 | 100 | |
index.js | 0 | 0 | 0 | 0 | |
src/components/PlayList | 100 | 100 | 100 | 100 | |
PlayList.jsx | 100 | 100 | 100 | 100 | |
PlayList.styled.js | 100 | 100 | 100 | 100 | |
index.js | 0 | 0 | 0 | 0 | |
src/components/PlayVideo | 100 | 100 | 100 | 100 | |
PlayVideo.jsx | 100 | 100 | 100 | 100 | |
PlayVideo.styled.js | 100 | 100 | 100 | 100 | |
index.js | 0 | 0 | 0 | 0 | |
src/components/Search | 100 | 100 | 100 | 100 | |
Search.jsx | 100 | 100 | 100 | 100 | |
Search.styled.js | 100 | 100 | 100 | 100 | |
index.js | 0 | 0 | 0 | 0 | |
src/components/ThemeButton | 100 | 100 | 100 | 100 | |
ThemeButton.jsx | 100 | 100 | 100 | 100 | |
ThemeButton.styled.js | 100 | 100 | 100 | 100 | |
index.js | 0 | 0 | 0 | 0 | |
src/components/VideoCard | 100 | 100 | 100 | 100 | |
VideoCard.jsx | 100 | 100 | 100 | 100 | |
VideoCard.styled.js | 100 | 100 | 100 | 100 | |
index.js | 0 | 0 | 0 | 0 | |
src/pages/Home | 90.91 | 83.33 | 100 | 100 | |
Home.page.jsx | 87.5 | 83.33 | 100 | 100 | 22 |
Home.styled.js | 100 | 100 | 100 | 100 | |
index.js | 0 | 0 | 0 | 0 | |
src/pages/Video | 78.57 | 25 | 100 | 78.57 | |
Video.jsx | 76 | 25 | 100 | 76 | 21,23,24,25,26,28 |
Video.styled.js | 100 | 100 | 100 | 100 | |
index.js | 0 | 0 | 0 | 0 | |
src/styles | 100 | 100 | 100 | 100 | |
MenuButton.js | 100 | 100 | 100 | 100 | |
----------------------------|----------|----------|----------|----------|-------------------|
Jest: "global" coverage threshold for statements (100%) not met: 89.09%
Jest: "global" coverage threshold for branches (100%) not met: 80%
Jest: "global" coverage threshold for lines (100%) not met: 89.81%
Jest: "global" coverage threshold for functions (100%) not met: 92%

Test Suites: 10 passed, 10 total
Tests: 16 passed, 16 total
Snapshots: 0 total
Time: 18.622s
Loading