This repository was archived by the owner on Aug 3, 2024. It is now read-only.
Autocomplete relevance field set for java+groovy code completions#501
Open
lukroth wants to merge 1 commit intoervandew:masterfrom
Open
Autocomplete relevance field set for java+groovy code completions#501lukroth wants to merge 1 commit intoervandew:masterfrom
lukroth wants to merge 1 commit intoervandew:masterfrom
Conversation
- To enable the eclim client to sort the proposals according to their relevance the relevance field is set. - The relevance field is not passed along when using compact mode -> fixed. This commit is a subset of the commit made for 'Autocomplete relevance ervandew#474'.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why we need this pull request:
We want to be able to sort the suggestion in our own eclim client. There is already a pull request (#474) which would allow us to do so. For our use case it is enough to have the relevance field set, such that our client then can sort the suggestions.
I wrote to @ocozalp and he told me he will not have time to go on with #474 right now -> #474 does not make process in the near time -> after a discussion with @ocozalp we both think that I should first add this change and then he will be able do his changes on top of this pull request. My changes are a subset (with the additional fix of that the relevance field is not passed along in compact mode) of the pull request #474. The difference to #474 is that this request does not change the original behavior of eclim since nothing gets sorted. (One open question in #474).
Content:
NOTE: Even if #474 would be accepted it would in my eyes make sense to add the changes of this request made in org.eclim.core/java/org/eclim/plugin/core/command/complete/AbstractCodeCompleteCommand.javaj