pregcomp2.c: Avoid using incompatible pointer type#100
Open
chrstphrchvz wants to merge 1 commit intoeserte:masterfrom
Open
pregcomp2.c: Avoid using incompatible pointer type#100chrstphrchvz wants to merge 1 commit intoeserte:masterfrom
chrstphrchvz wants to merge 1 commit intoeserte:masterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
See #98 (comment): Newer compilers may have
-Werror=incompatible-pointer-typesby default. Since pregcomp2.c does not dereference the result ofpregcomp2(), the result can be assigned tovoid *instead. There is already the regexp511.c configuration test to decide whether to useREGEXP *instead ofregexp *, but that test is run after pregcomp2.c.