Tk.xs: Grab() method should not return anything#81
Open
chrstphrchvz wants to merge 1 commit intoeserte:masterfrom
Open
Tk.xs: Grab() method should not return anything#81chrstphrchvz wants to merge 1 commit intoeserte:masterfrom
chrstphrchvz wants to merge 1 commit intoeserte:masterfrom
Conversation
Owner
|
The current situation is for sure wrong. Currently the method seems to return whatever is on top of the perl stack, which is probably not intended. However, the Grab() method (unlike the lowercase counterpart grab()) is not documented, nor can I find any usages of Grab() in the Tk code or even on CPAN. The original Tcl function returns TCL_OK or TCL_ERROR, which suggests that the method should rather return nothing, just throw an exception on errors. So maybe it would be better to change it to and change the return value of Tk_Grab to |
2454e99 to
3509c76
Compare
Address ParseXS warning: Warning: Found a 'CODE' section which seems to be using 'RETVAL' but no 'OUTPUT' section. in Tk.xs, line 1030
3509c76 to
ff7dbbe
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Address ParseXS warning:
Not sure if this is 100% correct or whether it fixes any actual bugs.