ci: add more linting checks#205
Merged
Merged
Conversation
Helps configure the very basics of editors in a way that conforms to the desired formatting – like indention width
Member
Author
|
Updated to also include an |
|
🎉 This PR is included in version 4.4.1 🎉 The release is available on: Your semantic-release bot 📦🚀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As a preparation for a PR that bumps our Node.js requirement (and as somewhat of an extraction from #204) I wanted to do this PR that extends our linting checks in three ways:
engines.nodedoesn't promise more than what our dependencies does (using myinstalled-check)knipto do all the kinds of checks that knip does.knipwill also be used ineslint/eslint: chore: Introduce Knip eslint/eslint#18005On top of that this PR also updates
npm-run-allto the maintained fork (maintained by @bcomnes with occasional assistance by me) + starts usingrun-pto run all of thelint:jobs in parallel, to gain some speed advantage.The
installed-checkscript is currently set toinstalled-check -v -i installed-check -i npm-run-all2 -i knipas all three of those have a tighterengines.noderequirement, but since all three of those are only run in linting and we don't need to run linting on older node.js versions, its okay.The
-von theinstalled-checkscript is used to output warnings, and it outputs that currently none of the used versions of opener, rimraf and vitepress are defining anengines.version, making it impossible forinstalled-checkto verify if they are inside or outside of ourengines.node.