Skip to content

chore: add lint:unused script to run Knip #241

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 14 commits into
base: main
Choose a base branch
from
Open

chore: add lint:unused script to run Knip #241

Show file tree
Hide file tree
Changes from 11 commits
Commits
Show all changes
14 commits
Select commit Hold shift + click to select a range
c64b8b9
chore: add lint:unused script to run Knip
JoshuaKGoldberg Jul 15, 2025
92424a2
Merge branch 'main'
JoshuaKGoldberg Aug 15, 2025
04af85b
Update packages/compat/tsconfig.json
JoshuaKGoldberg Aug 15, 2025
d140619
add back Knip and lint:unused script
JoshuaKGoldberg Aug 15, 2025
cb017d9
Reduced complaints back down to 0
JoshuaKGoldberg Aug 15, 2025
25a973b
Merge branch 'main'
JoshuaKGoldberg Sep 25, 2025
57f8101
Apply suggestion from @lumirlumir
JoshuaKGoldberg Sep 25, 2025
bda0a5d
Removed eslint/core from compat tsconfig
JoshuaKGoldberg Sep 25, 2025
8cb1ee9
Apply suggestion from @lumirlumir
JoshuaKGoldberg Sep 25, 2025
d10bd58
Apply suggestion from @lumirlumir
JoshuaKGoldberg Sep 25, 2025
d4bfef3
Standardize on cts,js,ts
JoshuaKGoldberg Sep 25, 2025
042aead
Apply suggestions from code review
JoshuaKGoldberg Oct 23, 2025
579b5ab
Merge branch 'main'
JoshuaKGoldberg Oct 23, 2025
bec181a
Add @types/node, and remove an eslint devDependency
JoshuaKGoldberg Oct 23, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions .github/workflows/ci.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -27,6 +27,9 @@ jobs:
- name: Lint Files
run: npm run lint

- name: Lint Files, Dependencies, & Exports
run: npm run lint:unused

- name: Check Formatting
run: npm run fmt:check

Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/manual-publish.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -67,7 +67,7 @@ jobs:
- name: Publish to JSR
run: |
if [ -f "jsr.json" ]; then
npx jsr publish
npx -y jsr publish
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It seems that everywhere else uses jsr@latest, only this one doesn't have @latest. 🤔

else
echo "No jsr.json file found, skipping JSR publish."
fi
Expand Down
37 changes: 37 additions & 0 deletions knip.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,37 @@
{
"$schema": "https://unpkg.com/knip@5/schema.json",
"ignore": ["templates/**/*"],
"workspaces": {
".": { "entry": ["scripts/*.js", "tools/*.js", ".github/workflows/*.yml"] },
"packages/compat": {
"ignoreDependencies": ["eslint"],
"entry": ["tests/**/*.{cts,js,ts}"],
"project": ["src/**/*.{cts,js,ts}", "tests/*.{cts,js,ts}"]
},
"packages/config-array": {
"entry": ["tests/**/*.{cts,js,ts}", "rollup.std__path-config.js"],
"project": ["src/**/*.{cts,js,ts}", "tests/**/*.{cts,js,ts}"]
},
"packages/config-helpers": {
"entry": ["tests/**/*.{cts,cts,js,ts}"],
"project": ["src/**/*.{cts,js,ts}", "tests/**/*.{cts,cts,js,ts}"]
},
"packages/core": { "project": ["src/**/*.{cts,js,ts}"] },
"packages/mcp": {
"entry": ["tests/**/*.{cts,js,ts}"],
"project": ["src/**/*.{cts,js,ts}", "tests/**/*.{cts,js,ts}"]
},
"packages/migrate-config": {
"entry": ["src/migrate-config.js", "tests/**/*.{cts,js,ts}"],
"project": ["src/**/*.{cts,js,ts}", "tests/*.{cts,js,ts}"]
},
"packages/object-schema": {
"entry": ["tests/**/*.{cts,js,ts}", "src/types.ts"],
"project": ["src/**/*.{cts,js,ts}", "tests/**/*.{cts,js,ts}"]
},
"packages/plugin-kit": {
"entry": ["tests/**/*.{cts,cts,js,ts}"],
"project": ["src/**/*.{cts,js,ts}", "tests/**/*.{cts,cts,js,ts}"]
}
}
}
2 changes: 2 additions & 0 deletions package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,6 +10,7 @@
"prepare": "npm run build",
"lint": "eslint",
"lint:fix": "eslint --fix",
"lint:unused": "knip",
"fmt": "prettier --write .",
"fmt:check": "prettier --check .",
"test:jsr": "npm run test:jsr --workspaces --if-present",
Expand Down Expand Up @@ -37,6 +38,7 @@
"c8": "^10.1.3",
"eslint": "^9.35.0",
"eslint-config-eslint": "^13.0.0",
"knip": "^5.62.0",
"lint-staged": "^15.2.0",
"mocha": "^11.5.0",
"prettier": "^3.4.1",
Expand Down
2 changes: 1 addition & 1 deletion packages/compat/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -27,7 +27,7 @@
"scripts": {
"build:cts": "node ../../tools/build-cts.js dist/esm/index.d.ts dist/cjs/index.d.cts",
"build": "rollup -c && tsc -p tsconfig.esm.json && npm run build:cts",
"test:jsr": "npx jsr@latest publish --dry-run",
"test:jsr": "npx -y jsr@latest publish --dry-run",
"test": "mocha \"tests/**/*.test.js\"",
"test:coverage": "c8 npm test"
},
Expand Down
3 changes: 2 additions & 1 deletion packages/compat/tsconfig.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,7 @@
"extends": "../../tsconfig.base.json",
"files": ["src/index.js"],
"compilerOptions": {
"outDir": "dist/esm"
"outDir": "dist/esm",
"types": ["mocha", "node"]
}
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Given these packages are all using mocha, I was wondering if we could move it to tsconfig.base.json? (That way we wouldn't have to add it in each package's tsconfig.json)

}
2 changes: 1 addition & 1 deletion packages/config-array/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -36,7 +36,7 @@
"build:cts": "node ../../tools/build-cts.js dist/esm/index.d.ts dist/cjs/index.d.cts",
"build:std__path": "rollup -c rollup.std__path-config.js && node fix-std__path-imports",
"build": "rollup -c && npm run build:dedupe-types && tsc -p tsconfig.esm.json && npm run build:cts && npm run build:std__path",
"test:jsr": "npx jsr@latest publish --dry-run",
"test:jsr": "npx -y jsr@latest publish --dry-run",
"pretest": "npm run build",
"test": "mocha \"tests/**/*.test.js\"",
"test:coverage": "c8 npm test"
Expand Down
3 changes: 2 additions & 1 deletion packages/config-array/tsconfig.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,7 @@
"extends": "../../tsconfig.base.json",
"files": ["src/index.js"],
"compilerOptions": {
"outDir": "dist/esm"
"outDir": "dist/esm",
"types": ["mocha"]
}
}
3 changes: 1 addition & 2 deletions packages/config-helpers/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -28,7 +28,7 @@
"build:dedupe-types": "node ../../tools/dedupe-types.js dist/cjs/index.cjs dist/esm/index.js",
"build:cts": "node ../../tools/build-cts.js dist/esm/index.d.ts dist/cjs/index.d.cts",
"build": "rollup -c && npm run build:dedupe-types && tsc -p tsconfig.esm.json && npm run build:cts",
"test:jsr": "npx jsr@latest publish --dry-run",
"test:jsr": "npx -y jsr@latest publish --dry-run",
"test": "mocha \"tests/**/*.test.js\"",
"test:coverage": "c8 npm test",
"test:types": "tsc -p tests/types/tsconfig.json"
Expand All @@ -50,7 +50,6 @@
"@eslint/core": "^0.16.0"
},
"devDependencies": {
"eslint": "^9.27.0",
"rollup-plugin-copy": "^3.5.0"
},
"engines": {
Expand Down
2 changes: 1 addition & 1 deletion packages/core/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,7 +19,7 @@
"scripts": {
"build:cts": "node -e \"fs.cpSync('dist/esm/types.d.ts', 'dist/cjs/types.d.cts')\"",
"build": "tsc && npm run build:cts",
"test:jsr": "npx jsr@latest publish --dry-run",
"test:jsr": "npx -y jsr@latest publish --dry-run",
"test:types": "tsc -p tests/types/tsconfig.json"
},
"repository": {
Expand Down
3 changes: 2 additions & 1 deletion packages/migrate-config/tsconfig.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,7 @@
"extends": "../../tsconfig.base.json",
"files": ["src/migrate-config-cli.js"],
"compilerOptions": {
"outDir": "dist/esm"
"outDir": "dist/esm",
"types": ["mocha"]
}
}
2 changes: 1 addition & 1 deletion packages/object-schema/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -27,7 +27,7 @@
"scripts": {
"build:cts": "node ../../tools/build-cts.js dist/esm/index.d.ts dist/cjs/index.d.cts",
"build": "rollup -c && tsc -p tsconfig.esm.json && npm run build:cts",
"test:jsr": "npx jsr@latest publish --dry-run",
"test:jsr": "npx -y jsr@latest publish --dry-run",
"test": "mocha \"tests/**/*.test.js\"",
"test:coverage": "c8 npm test"
},
Expand Down
3 changes: 2 additions & 1 deletion packages/object-schema/tsconfig.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,7 @@
"extends": "../../tsconfig.base.json",
"files": ["src/index.js"],
"compilerOptions": {
"outDir": "dist/esm"
"outDir": "dist/esm",
"types": ["mocha"]
}
}
2 changes: 1 addition & 1 deletion packages/plugin-kit/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -38,7 +38,7 @@
"pretest": "npm run build",
"test": "mocha \"tests/**/*.test.js\"",
"test:coverage": "c8 npm test",
"test:jsr": "npx jsr@latest publish --dry-run",
"test:jsr": "npx -y jsr@latest publish --dry-run",
"test:types": "tsc -p tests/types/tsconfig.json"
},
"keywords": [
Expand Down
3 changes: 2 additions & 1 deletion packages/plugin-kit/tsconfig.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,6 +3,7 @@
"files": ["src/index.js"],
"compilerOptions": {
"outDir": "dist/esm",
"strict": true
"strict": true,
"types": ["mocha"]
}
}
2 changes: 1 addition & 1 deletion scripts/publish.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -159,7 +159,7 @@ function publishPackagesToJsr(packageDirs) {

console.log(`Publishing ${packageDir}...`);
try {
exec(`npx jsr publish`, {
exec(`npx -y jsr publish`, {
stdio: "inherit",
env: process.env,
cwd: packageDir,
Expand Down
2 changes: 1 addition & 1 deletion templates/package/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -28,7 +28,7 @@
"build:dedupe-types": "node ../../tools/dedupe-types.js dist/cjs/index.cjs dist/esm/index.js",
"build:cts": "node ../../tools/build-cts.js dist/esm/index.d.ts dist/cjs/index.d.cts",
"build": "rollup -c && npm run build:dedupe-types && tsc -p tsconfig.esm.json && npm run build:cts",
"test:jsr": "npx jsr@latest publish --dry-run",
"test:jsr": "npx -y jsr@latest publish --dry-run",
"test": "mocha \"tests/**/*.test.js\"",
"test:coverage": "c8 npm test"
},
Expand Down
Loading