Skip to content

chore: Update dependencies #9

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
May 20, 2025
Merged

chore: Update dependencies #9

merged 4 commits into from
May 20, 2025

Conversation

finger563
Copy link
Contributor

Description

  • Remove espp submodule, instead using idf-component-manager dependencies
  • Remove esp-protocols submodule, instead using idf-component-manager dependencies
  • Update jpegdec submodule to latest
  • Update code to use latest espp::Task API
  • Add dependencies file
  • Update CMakeLists accordingly
  • Update sdkconfig

Motivation and Context

Keeps this repo up to date with latest features and bugfixes.

How has this been tested?

Building and running main on ESP-S3-BOX hardware and ensuring it still receives the video data and decodes/displays it appropriately.

Screenshots (if appropriate, e.g. schematic, board, console logs, lab pictures):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation Update
  • Hardware (schematic, board, system design) change
  • Software change

Checklist:

  • My change requires a change to the documentation.
  • I have added / updated the documentation related to this change via either README or WIKI

Software

  • I have added tests to cover my changes.
  • I have updated the .github/workflows/build.yml file to add my new test to the automated cloud build github action.
  • All new and existing tests passed.
  • My code follows the code style of this project.

Copy link

github-actions bot commented May 20, 2025

✅Static analysis result - no issues found! ✅

@finger563 finger563 requested a review from Copilot May 20, 2025 16:03
@finger563 finger563 self-assigned this May 20, 2025
@finger563 finger563 added the enhancement New feature or request label May 20, 2025
Copy link

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR updates project dependencies by removing unused submodules and adjusting configurations to align with the latest dependency versions and APIs. Key changes include replacing the espp and esp-protocols submodules with idf-component-manager dependencies, updating the SPIRAM configurations in sdkconfig.defaults, and modifying code and workflows to use the latest espp::Task API and ESP-IDF v5.4.

Reviewed Changes

Copilot reviewed 11 out of 11 changed files in this pull request and generated 1 comment.

Show a summary per file
File Description
sdkconfig.defaults Updated SPIRAM configuration options to use malloc and 120M speed
main/main.cpp Modified task initialization to match the new espp::Task API
main/idf_component.yml Added dependency manifest for idf-component-manager
components/jpegdec Updated submodule commit for jpegdec
components/espp & components/esp-protocols Removed submodules for espp and esp-protocols
CMakeLists.txt Removed obsolete extra component directories
.gitmodules Removed espp and esp-protocols submodule definitions
.github/workflows/static_analysis.yml Updated ESP-IDF version and removed submodule exclusions for cppcheck
.github/workflows/package_main.yml Updated workflow steps to reflect removal of submodules and add intermediary outputs
.github/workflows/build.yml Updated submodules checkout option and ESP-IDF version
Comments suppressed due to low confidence (2)

main/main.cpp:181

  • The new designated initializer for espp::Task::make_unique requires that Task be an aggregate type or otherwise support such initialization. Verify that the Task API in use and the C++ standard in your build environment support designated initializers.
auto display_task = espp::Task::make_unique({.callback = display_task_fn,

.github/workflows/build.yml:14

  • Ensure that using 'submodules: true' behaves equivalently to the previous 'recursive' option in terms of fetching all necessary submodules. This verification helps avoid potential issues if repository submodule structures change in the future.
submodules: true

@finger563 finger563 merged commit c447bed into main May 20, 2025
2 checks passed
@finger563 finger563 deleted the chore/dep-update branch May 20, 2025 16:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant