fix: reduce ALB target group deregistration delay from 600s to 30s#29
Open
jesserockz wants to merge 1 commit into
Open
fix: reduce ALB target group deregistration delay from 600s to 30s#29jesserockz wants to merge 1 commit into
jesserockz wants to merge 1 commit into
Conversation
…rom 600 to 30 seconds
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The ALB target group
deregistration_delayis set to the AWS default of 600 seconds (10 minutes). This means every rolling deployment waits up to 10 minutes for the old task to drain before completing, even though the service handles short-lived webhook requests with no long-running connections.Change
.modules/webservice/network.tf:deregistration_delay600 → 30 secondsReasoning
The
service-hub-botsworkload is entirely stateless — inbound traffic is GitHub webhooks and CLA sign callbacks, all of which complete well within a few seconds. A 30 second drain window is more than sufficient and matches the actual connection lifecycle.Impact
deployment_maximum_percent = 200), which marginally reduces Fargate compute usage per deploy