[mitsubishi_cn105] Add documentation for Mitsubishi CN105 climate component#6313
[mitsubishi_cn105] Add documentation for Mitsubishi CN105 climate component#6313crnjan wants to merge 2 commits intoesphome:nextfrom
Conversation
There was a problem hiding this comment.
As this is a feature matched with a PR in https://github.com/esphome/esphome, please target your PR to the next branch and rebase.
|
Please take a look at the requested changes, and use the Ready for review button when you are done, thanks 👍 |
WalkthroughAdded comprehensive documentation page for the Mitsubishi CN105 climate component, including hardware communication details, wiring instructions, pinout diagram, YAML configuration examples, and supported features. Updated the documentation component index to reference the new page. Changes
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~5 minutes Suggested labels
Suggested reviewers
🚥 Pre-merge checks | ✅ 3✅ Passed checks (3 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment Tip You can make CodeRabbit's review stricter and more nitpicky using the `assertive` profile, if that's what you prefer.Change the |
There was a problem hiding this comment.
Actionable comments posted: 1
🧹 Nitpick comments (1)
src/content/docs/components/climate/mitsubishi_cn105.mdx (1)
51-58: Make UART framing fields explicit in the example config.The prose says 8 data bits and 1 stop bit are required; adding those keys directly to the YAML example avoids ambiguity for copy/paste users.
Suggested tweak
uart: id: ac_uart tx_pin: GPIO1 rx_pin: GPIO3 + data_bits: 8 baud_rate: 2400 parity: EVEN + stop_bits: 1🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed. In `@src/content/docs/components/climate/mitsubishi_cn105.mdx` around lines 51 - 58, The example UART YAML in the Mitsubishi CN105 doc omits framing fields; update the uart example block (the mapping with id: ac_uart, tx_pin: GPIO1, rx_pin: GPIO3, baud_rate: 2400, parity: EVEN) to include explicit data_bits: 8 and stop_bits: 1 so the config matches the prose and is unambiguous for copy/paste users.
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.
Inline comments:
In `@src/content/docs/components/index.mdx`:
- Line 696: The ImgTable row added in the components index uses a relative image
filename ("mitsubishi_electric.png") which violates the ImgTable convention;
update the image reference in the array entry (the row for "Mitsubishi CN105
Climate") to the absolute path under /images/ (e.g., "/images/…") so it points
to the file stored in /public/images/, ensuring the ImgTable entry uses the
absolute image path convention.
---
Nitpick comments:
In `@src/content/docs/components/climate/mitsubishi_cn105.mdx`:
- Around line 51-58: The example UART YAML in the Mitsubishi CN105 doc omits
framing fields; update the uart example block (the mapping with id: ac_uart,
tx_pin: GPIO1, rx_pin: GPIO3, baud_rate: 2400, parity: EVEN) to include explicit
data_bits: 8 and stop_bits: 1 so the config matches the prose and is unambiguous
for copy/paste users.
ℹ️ Review info
⚙️ Run configuration
Configuration used: Organization UI
Review profile: CHILL
Plan: Pro
Run ID: 19b8d9a1-ca44-49ac-a532-3873ff547297
⛔ Files ignored due to path filters (2)
public/images/mitsubishi_electric.pngis excluded by!**/*.pngsrc/content/docs/components/climate/images/cn105_wiring.pngis excluded by!**/*.png
📒 Files selected for processing (2)
src/content/docs/components/climate/mitsubishi_cn105.mdxsrc/content/docs/components/index.mdx
✅ Deploy Preview for esphome ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
Base branch has been corrected - dismissing previous review.
f6f6bd3 to
4388add
Compare
Description
Adds documentation for the Mitsubishi CN105 climate platform.
Pull request in esphome with YAML changes (if applicable):
Checklist
I am merging into
nextbecause this is new documentation that has a matching pull-request in esphome as linked above.or
I am merging into
currentbecause this is a fix, change and/or adjustment in the current documentation and is not for a new component or feature.Link added in
/src/content/docs/components/index.mdxwhen creating new documents for new components or cookbook.