[cc1101] Fix magn_target valid values#6804
Conversation
✅ Deploy Preview for esphome ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
There was a problem hiding this comment.
Pull request overview
Updates the CC1101 component documentation to accurately describe the valid magn_target AGC configuration values, replacing an incorrect “3 dB increments” range description with the explicit supported set.
Changes:
- Replaced the
magn_target“Range … increments of 3” text with an explicit options list (24, 27, 30, 33, 36, 38, 40, 42dB). - Kept the default value documentation (
42dB) unchanged.
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (1)
WalkthroughThe ChangesCC1101 AGC Documentation Fix
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~2 minutes 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Description:
The
magn_targetconfig variable was documented as "Range:24dBto42dBin increments of 3". That is incorrect — the CC1101's AGCMAGN_TARGETvalues are not uniform 3 dB steps. The valid values (per the enum incc1101/__init__.py) are24, 27, 30, 33, 36, 38, 40, 42dB (3 dB steps up to 36 dB, then 2 dB steps). Replaced the range text with the explicit list of options.Related issue (if applicable): N/A
Pull request in esphome with YAML changes (if applicable):
Checklist:
I am merging into
nextbecause this is new documentation that has a matching pull-request in esphome as linked above.or
I am merging into
currentbecause this is a fix, change and/or adjustment in the current documentation and is not for a new component or feature.Link added in
/components/_index.mdwhen creating new documents for new components or cookbook.