-
Notifications
You must be signed in to change notification settings - Fork 7.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
made fix to the ESP32 I2S simple tone example #10954
base: master
Are you sure you want to change the base?
Conversation
👋 Hello greenyleaf, we appreciate your contribution to this project! 📘 Please review the project's Contributions Guide for key guidelines on code, documentation, testing, and more. 🖊️ Please also make sure you have read and signed the Contributor License Agreement for this project. Click to see more instructions ...
Review and merge process you can expect ...
|
How to accomplish the requirement of the 'Test needed' tag? |
@greenyleaf we will test it and comment. No worries |
Fixed a problem in the I2S tone example.
Description of Change
Did some fix so that the tone example could play normally on ESP32 board with I2S decoder attached.
Tests scenarios
Tested the Pull Request on Arduino-esp32 core v3.1.0 with ESP32 and ESP32-S3 Board with this scenario.