-
Notifications
You must be signed in to change notification settings - Fork 7.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: Geekble Nano board setup update #11131
Conversation
Geekble Nano board setup update
👋 Hello SooDragon, we appreciate your contribution to this project! 📘 Please review the project's Contributions Guide for key guidelines on code, documentation, testing, and more. 🖊️ Please also make sure you have read and signed the Contributor License Agreement for this project. Click to see more instructions ...
Review and merge process you can expect ...
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you please clear the commented lines, so it's clear what are the changes?
Also keep the old name Geekble_Nano_ESP32S3
, if there is not a good reason for that change.
In my environment, the old name Geekble_Nano_ESP32S3 resulted Errors, but new name Geekble_nano_ESP32S3 is fine. may I keep the new name? and also, reason for commented line was for Heavy-Users. may I also keep the commented lines please? Thank you! @P-R-O-C-H-Y |
Can you add some log with the other naming (original) which is having troubles? |
About the commented lines, please remove those to keep it clear. None of the boards have huge commented parts. |
fix: erase Comment Line
@P-R-O-C-H-Y I erased the comment lines and and added logs. Thank you! |
Where is the log file? |
On the description :) |
@SooDragon Please check mine and @Jason2866 comment. |
I dont see any error log there, which is reasoning the name change. |
fix log : Changed Board name : Geekble_Nano_ESP32S3 to Geekble_nano_ESP32S3 to resolve Tools menu error was What I added, sorry for repeated requests, is there any suggestions or sample for adding error log? |
For the boards name change there needs to be a reason. Post the log showing it fails using the not changed original board name. |
I Updated the log! |
I have no issues with compiling the Geekble nano S3 as it is now without your changes. |
The changes are focused on Helping Arduino Beginners, So with my changes, They will see less Tools options might confuse them :) |
OK so please revert the name change and remove only the necessary stuff you would like to hide from users :) |
Yes It's applied could you check it out?
|
@SooDragon You are still renaming, which is not necessary as I messaged. I did test the board with the "old" name and there is no issue. So please revert the naming back and do only the 1. and 3. point for your comment. Also please check again if the variant folder name matches the variant name in boards.txt |
revert re-naming
Thank you for your patience and support.
Thank you! @P-R-O-C-H-Y |
Geekble Nano board setup update
Description of Change
Geekble Nano board setup update
fix log : Changed Board name : Geekble_Nano_ESP32S3 to Geekble_nano_ESP32S3 to resolve Tools menu error

for Old name "Geekble_Nano_ESP32S3", Compile Error and Tools Menu Error Occurs.
for New name "Geekble_nano_Esp32S3", Errors are Corrected.
Tests scenarios
Tested under Arduino IDE 2.3.4 with Geekble nano 2.0 Dev Board
Related links