-
Notifications
You must be signed in to change notification settings - Fork 7.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove superfluous warnings for board Arduino nano #11157
Conversation
👋 Hello Jason2866, we appreciate your contribution to this project! 📘 Please review the project's Contributions Guide for key guidelines on code, documentation, testing, and more. 🖊️ Please also make sure you have read and signed the Contributor License Agreement for this project. Click to see more instructions ...
Review and merge process you can expect ...
|
@pillo79 PTAL! |
Thanks for the ping! I am OK with deleting the second part, it is an user choice after all, so why complain 🙂 But please keep the first part: #if !defined(BOARD_HAS_PIN_REMAP)
// This board uses pin mapping but the build system has disabled it
#warning The build system forces the Arduino API to use GPIO numbers on a board that has custom pin mapping.
We had lots of users that complained about using third party build systems that did not properly export the macros related to pin mapping, and that helped expose those issues. It definitely does never appear unless there is a problem with the build system (and if so, it needs to be clear!). |
Closing since there will still be unnecessary warnings. So it can be left as it is. |
Align behavior with other settings choosen from user. There is no warning for the selections made anywhere else.
To do remapping or not is a setting as every other selection done in config.
There is no reason to generate warnings.