Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove superfluous warnings for board Arduino nano #11157

Closed
wants to merge 1 commit into from

Conversation

Jason2866
Copy link
Collaborator

@Jason2866 Jason2866 commented Mar 21, 2025

Align behavior with other settings choosen from user. There is no warning for the selections made anywhere else.

To do remapping or not is a setting as every other selection done in config.
There is no reason to generate warnings.

Copy link
Contributor

github-actions bot commented Mar 21, 2025

Warnings
⚠️

Some issues found for the commit messages in this PR:

  • the commit message "Remove superfluous warnings for board Arduino nano":
    • summary looks empty
    • type/action looks empty

Please fix these commit messages - here are some basic tips:

  • follow Conventional Commits style
  • correct format of commit message should be: <type/action>(<scope/component>): <summary>, for example fix(esp32): Fixed startup timeout issue
  • allowed types are: change,ci,docs,feat,fix,refactor,remove,revert,test
  • sufficiently descriptive message summary should be between 10 to 72 characters and start with upper case letter
  • avoid Jira references in commit messages (unavailable/irrelevant for our customers)

TIP: Install pre-commit hooks and run this check when committing (uses the Conventional Precommit Linter).

👋 Hello Jason2866, we appreciate your contribution to this project!


📘 Please review the project's Contributions Guide for key guidelines on code, documentation, testing, and more.

🖊️ Please also make sure you have read and signed the Contributor License Agreement for this project.

Click to see more instructions ...


This automated output is generated by the PR linter DangerJS, which checks if your Pull Request meets the project's requirements and helps you fix potential issues.

DangerJS is triggered with each push event to a Pull Request and modify the contents of this comment.

Please consider the following:
- Danger mainly focuses on the PR structure and formatting and can't understand the meaning behind your code or changes.
- Danger is not a substitute for human code reviews; it's still important to request a code review from your colleagues.
- Resolve all warnings (⚠️ ) before requesting a review from human reviewers - they will appreciate it.
- To manually retry these Danger checks, please navigate to the Actions tab and re-run last Danger workflow.

Review and merge process you can expect ...


We do welcome contributions in the form of bug reports, feature requests and pull requests.

1. An internal issue has been created for the PR, we assign it to the relevant engineer.
2. They review the PR and either approve it or ask you for changes or clarifications.
3. Once the GitHub PR is approved we do the final review, collect approvals from core owners and make sure all the automated tests are passing.
- At this point we may do some adjustments to the proposed change, or extend it by adding tests or documentation.
4. If the change is approved and passes the tests it is merged into the default branch.

Generated by 🚫 dangerJS against a5be755

@SuGlider SuGlider added this to the 3.2.0 milestone Mar 21, 2025
@me-no-dev
Copy link
Member

@pillo79 PTAL!

@pillo79
Copy link
Contributor

pillo79 commented Mar 24, 2025

Thanks for the ping! I am OK with deleting the second part, it is an user choice after all, so why complain 🙂 But please keep the first part:

#if !defined(BOARD_HAS_PIN_REMAP)
// This board uses pin mapping but the build system has disabled it
#warning The build system forces the Arduino API to use GPIO numbers on a board that has custom pin mapping.

We had lots of users that complained about using third party build systems that did not properly export the macros related to pin mapping, and that helped expose those issues. It definitely does never appear unless there is a problem with the build system (and if so, it needs to be clear!).

@Jason2866
Copy link
Collaborator Author

Closing since there will still be unnecessary warnings. So it can be left as it is.

@Jason2866 Jason2866 closed this Mar 24, 2025
@Jason2866 Jason2866 deleted the patch-4 branch March 24, 2025 14:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Development

Successfully merging this pull request may close these issues.

5 participants