Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(wifi): Workaround bug in esp_wifi_get_protocol() #11239

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

me-no-dev
Copy link
Member

This pull request includes changes to the WiFiGenericClass::mode method in the WiFiGeneric.cpp file. The changes involve updating the data type of the current_protocol variable and modifying the way its address is passed to the esp_wifi_get_protocol function. This is required, because esp_wifi_get_protocol sets more than one byte in the provided return mask.

Data type and casting updates:

  • Changed the data type of current_protocol from uint8_t to uint32_t to accommodate a wider range of values.
  • Updated the esp_wifi_get_protocol function calls to cast the address of current_protocol to uint8_t* to match the expected parameter type. [1] [2]

Fixes: #11218

Copy link
Contributor

Messages
📖 🎉 Good Job! All checks are passing!

👋 Hello me-no-dev, we appreciate your contribution to this project!


📘 Please review the project's Contributions Guide for key guidelines on code, documentation, testing, and more.

🖊️ Please also make sure you have read and signed the Contributor License Agreement for this project.

Click to see more instructions ...


This automated output is generated by the PR linter DangerJS, which checks if your Pull Request meets the project's requirements and helps you fix potential issues.

DangerJS is triggered with each push event to a Pull Request and modify the contents of this comment.

Please consider the following:
- Danger mainly focuses on the PR structure and formatting and can't understand the meaning behind your code or changes.
- Danger is not a substitute for human code reviews; it's still important to request a code review from your colleagues.
- To manually retry these Danger checks, please navigate to the Actions tab and re-run last Danger workflow.

Review and merge process you can expect ...


We do welcome contributions in the form of bug reports, feature requests and pull requests.

1. An internal issue has been created for the PR, we assign it to the relevant engineer.
2. They review the PR and either approve it or ask you for changes or clarifications.
3. Once the GitHub PR is approved we do the final review, collect approvals from core owners and make sure all the automated tests are passing.
- At this point we may do some adjustments to the proposed change, or extend it by adding tests or documentation.
4. If the change is approved and passes the tests it is merged into the default branch.

Generated by 🚫 dangerJS against e37fbb3

Copy link
Contributor

Memory usage test (comparing PR against master branch)

The table below shows the summary of memory usage change (decrease - increase) in bytes and percentage for each target.

MemoryFLASH [bytes]FLASH [%]RAM [bytes]RAM [%]
TargetDECINCDECINCDECINCDECINC
ESP32P4💚 -1200.000.00000.000.00
ESP32S3💚 -1200.000.00000.000.00
ESP32S2💚 -1200.000.00000.000.00
ESP32C3💚 -1000.000.00000.000.00
ESP32C6💚 -1000.000.00000.000.00
ESP32000.000.00000.000.00
Click to expand the detailed deltas report [usage change in BYTES]
TargetESP32P4ESP32S3ESP32S2ESP32C3ESP32C6ESP32
ExampleFLASHRAMFLASHRAMFLASHRAMFLASHRAMFLASHRAMFLASHRAM
libraries/WiFi/examples/FTM/FTM_Initiator💚 -1000000💚 -100💚 -10000
libraries/WiFi/examples/FTM/FTM_Responder💚 -1000000💚 -100💚 -10000
libraries/WiFi/examples/SimpleWiFiServer💚 -1000000💚 -100💚 -10000
libraries/WiFi/examples/WiFiAccessPoint💚 -100💚 -12000💚 -100💚 -10000
libraries/WiFi/examples/WiFiClient💚 -1000000💚 -100💚 -10000
libraries/WiFi/examples/WiFiClientBasic💚 -1000000💚 -100💚 -10000
libraries/WiFi/examples/WiFiClientConnect💚 -1000000💚 -100💚 -10000
libraries/WiFi/examples/WiFiClientEvents💚 -100💚 -12000💚 -100💚 -10000
libraries/WiFi/examples/WiFiClientStaticIP💚 -1200000💚 -100💚 -10000
libraries/WiFi/examples/WiFiExtender💚 -1000000💚 -100💚 -10000
libraries/WiFi/examples/WiFiIPv6💚 -1000000💚 -100💚 -10000
libraries/WiFi/examples/WiFiMulti💚 -1000000💚 -100💚 -10000
libraries/WiFi/examples/WiFiMultiAdvanced💚 -1000000💚 -100💚 -10000
libraries/WiFi/examples/WiFiScan💚 -1000000💚 -100💚 -10000
libraries/WiFi/examples/WiFiScanAsync💚 -1000000💚 -100💚 -10000
libraries/WiFi/examples/WiFiScanDualAntenna💚 -1000000💚 -100💚 -10000
libraries/WiFi/examples/WiFiScanTime💚 -1000000💚 -100💚 -10000
libraries/WiFi/examples/WiFiTelnetToSerial💚 -1000000💚 -100💚 -10000
libraries/WiFi/examples/WiFiUDPClient💚 -10000💚 -120💚 -100💚 -10000
libraries/WiFi/examples/WPS--00💚 -120💚 -100💚 -10000
libraries/WiFi/examples/WiFiBlueToothSwitch--00--💚 -100💚 -10000
libraries/WiFi/examples/WiFiClientEnterprise--0000💚 -100💚 -10000
libraries/WiFi/examples/WiFiSmartConfig--0000💚 -100💚 -10000

Copy link
Contributor

github-actions bot commented Apr 11, 2025

Test Results

 76 files   76 suites   12m 40s ⏱️
 38 tests  38 ✅ 0 💤 0 ❌
241 runs  241 ✅ 0 💤 0 ❌

Results for commit e37fbb3.

♻️ This comment has been updated with latest results.

@P-R-O-C-H-Y P-R-O-C-H-Y added the Area: WiFi Issue related to WiFi label Apr 11, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Area: WiFi Issue related to WiFi
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Buffer overflow / stack smashing in WiFiGenericClass::mode()
3 participants