Skip to content

Adds ESP32-BOX-3 #8989

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 5 commits into from
Closed

Adds ESP32-BOX-3 #8989

wants to merge 5 commits into from

Conversation

SuGlider
Copy link
Collaborator

Description of Change

Adds the ESP-BOX-3 board. It is different from ESP-BOX by a few things:

  • It has no Accelerometer
  • GPIO47 is the Backlight, while BOX uses GPIO45
  • GPIO45 is the I2S LCLK, while BOX uses GPIO47
  • 2 options for Display + Touch Screen => ILI9341+GT911 or ST7789+TT21100
  • BOX3 has SD_MMC + SD Card Slot

Tests scenarios

Related links

Closes #8978

@SuGlider SuGlider self-assigned this Dec 12, 2023
@SuGlider SuGlider marked this pull request as draft December 12, 2023 21:42
Copy link
Contributor

github-actions bot commented Dec 12, 2023

Warnings
⚠️

Some issues found for the commit messages in this PR:

  • the commit message "Adds Box3 to boards.txt":
    • summary looks empty
    • type/action looks empty
  • the commit message "Adds SD pins and LCD definitions":
    • summary looks empty
    • type/action looks empty
  • the commit message "ESP-Box-3 pins_arduino.h":
    • summary looks empty
    • type/action looks empty
  • the commit message "Fix Variant Folder":
    • summary looks empty
    • type/action looks empty
  • the commit message "LCD resolution":
    • summary looks empty
    • type/action looks empty

Please fix these commit messages - here are some basic tips:

  • follow Conventional Commits style
  • correct format of commit message should be: <type/action>(<scope/component>): <summary>, for example fix(esp32): Fixed startup timeout issue
  • allowed types are: change,ci,docs,feat,fix,refactor,remove,revert
  • sufficiently descriptive message summary should be between 20 to 72 characters and start with upper case letter
  • avoid Jira references in commit messages (unavailable/irrelevant for our customers)

TIP: Install pre-commit hooks and run this check when committing (uses the Conventional Precommit Linter).

⚠️

The source branch "SuGlider-patch-1" incorrect format:

  • contains uppercase letters. This can cause troubles on case-insensitive file systems (macOS).
    Please rename your branch.
Messages
📖 You might consider squashing your 5 commits (simplifying branch history).

👋 Hello SuGlider, we appreciate your contribution to this project!


Click to see more instructions ...


This automated output is generated by the PR linter DangerJS, which checks if your Pull Request meets the project's requirements and helps you fix potential issues.

DangerJS is triggered with each push event to a Pull Request and modify the contents of this comment.

Please consider the following:
- Danger mainly focuses on the PR structure and formatting and can't understand the meaning behind your code or changes.
- Danger is not a substitute for human code reviews; it's still important to request a code review from your colleagues.
- Resolve all warnings (⚠️ ) before requesting a review from human reviewers - they will appreciate it.
- Addressing info messages (📖) is strongly recommended; they're less critical but valuable.
- To manually retry these Danger checks, please navigate to the Actions tab and re-run last Danger workflow.

Review and merge process you can expect ...


We do welcome contributions in the form of bug reports, feature requests and pull requests.

1. An internal issue has been created for the PR, we assign it to the relevant engineer.
2. They review the PR and either approve it or ask you for changes or clarifications.
3. Once the GitHub PR is approved we do the final review, collect approvals from core owners and make sure all the automated tests are passing.
- At this point we may do some adjustments to the proposed change, or extend it by adding tests or documentation.
4. If the change is approved and passes the tests it is merged into the default branch.

Generated by 🚫 dangerJS against e34a420

@me-no-dev
Copy link
Member

Given that we will add a BSP as soon as the bulk of changes for 3.0.0 are done, this might be a bit premature. Saying this because the definitions in pins_arduino.h will have to change, which will cause issues if someone already started using them as they are here.

@me-no-dev
Copy link
Member

@SuGlider will close this and leave the pending issue to remind us (not that we need a reminder for this particular board)

@me-no-dev me-no-dev closed this Jan 31, 2024
@me-no-dev me-no-dev deleted the SuGlider-patch-1 branch February 28, 2024 16:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Development

Successfully merging this pull request may close these issues.

Board support for ESP32-BOX-3
3 participants