esp_wifi: require SHA1 for SoftAP (IDFGH-17711)#18650
Open
dhimasardinata wants to merge 1 commit into
Open
Conversation
SoftAP password handling relies on SHA-1. Keep the dependency explicit so disabling SHA-1 in mbedTLS does not leave SoftAP misconfigured. Closes espressif#18508
github-actions
Bot
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
MBEDTLS_SHA1_Cwhen regular SoftAP support is enabled.Verification
git diff --checkpython tools/ci/check_kconfigs.py components/esp_wifi/Kconfig components/esp_wifi/remote/Kconfig.wifi.inidf.py -C examples/wifi/getting_started/softAP -B /tmp/softap_sha1_build -D SDKCONFIG=/tmp/softap_sha1_sdkconfig -D SDKCONFIG_DEFAULTS=/tmp/softap-sha1-off.defaults set-target esp32 buildrg "CONFIG_(ESP_WIFI_SOFTAP_SUPPORT|MBEDTLS_SHA1_C)" /tmp/softap_sha1_sdkconfig /tmp/softap_sha1_build/config/sdkconfig.hCloses #18508