example/softap_sta: fix missing STA_DISCONNECTED handler (IDFGH-17730)#18662
Open
hphuc15 wants to merge 1 commit into
Open
example/softap_sta: fix missing STA_DISCONNECTED handler (IDFGH-17730)#18662hphuc15 wants to merge 1 commit into
hphuc15 wants to merge 1 commit into
Conversation
- Without this handler, WIFI_FAIL_BIT is never set after connection failure. s_retry_num was declared but never incremented. - Also remove failure_retry_cnt from STA config to be consistent with the getting_started/station example with uses app-level retry only. Signed-off-by: Võ Hồng Phúc <hphuc15@outlook.com.vn>
|
|
github-actions
Bot
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
The WIFI_EVENT_STA_DISCONNECTED handler was missing, causing WIFI_FAIL_BIT
to never be set after connection failure. This results in
xEventGroupWaitBits() blocking indefinitely in app_main().
Also removed failure_retry_cnt from STA config to be consistent with
the getting_started/station example which uses app-level retry only.
Related
N/A
Testing
Tested on ESP32/ESP32-S3 with incorrect WiFi credentials to verify WIFI_FAIL_BIT
is set correctly after EXAMPLE_ESP_MAXIMUM_RETRY attempts. Device exits
xEventGroupWaitBits() as expected with WIFI_FAIL_BIT set.
Checklist
Before submitting a Pull Request, please ensure the following: