[modem]: tcp-client example to support multiple connections #849
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
david-cermak
force-pushed
the
feat/modem_tcp_client_multi_conn
branch
from
bff08c4 to
de6500e
Compare
david-cermak
force-pushed
the
feat/modem_tcp_client_multi_conn
branch
4 times, most recently
from
0922062 to
171c30f
Compare
components/esp_modem/examples/modem_tcp_client/main/generate/sock_dce.cpp
Outdated
Show resolved
Hide resolved
components/esp_modem/examples/modem_tcp_client/main/generate/sock_dce.cpp
Outdated
Show resolved
Hide resolved
| #include "tcp_transport_at.h" | ||
|
|
||
| #define BROKER_URL "test.mosquitto.org" | ||
| #define USE_TLS 0 |
There was a problem hiding this comment.
This defines could be simplified by having the URL define directly without composing the macros. Also is the USE_TLS define a left over?
There was a problem hiding this comment.
Added those configs to Kconfig, so users chould choose.
Also is the USE_TLS define a left over?
It's not, as in this example the code is different for TCP and TLS connection (we use different tcp_transport() instances)
david-cermak
force-pushed
the
feat/modem_tcp_client_multi_conn
branch
from
171c30f to
e376527
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Support for multiple connections via AT based DCE