[modem]: Enhanced URC handling #883
Open
+1,799
−40
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
||
| void set_enhanced_urc(esp_modem::DTE::enhanced_urc_cb enhanced_cb) | ||
| { | ||
| dte->set_enhanced_urc_cb(enhanced_cb); |
Collaborator
There was a problem hiding this comment.
Do we need to check for valid callback?
Collaborator
Author
There was a problem hiding this comment.
No need IMO, I use nullptr value for clearing the cb
| std::string_view buffer((const char*)info.buffer_start, info.buffer_total_size); | ||
|
|
||
| // First, check if we have the completion message anywhere in the buffer | ||
| if (buffer.find("Transfer completed") != std::string_view::npos) { |
Collaborator
Author
There was a problem hiding this comment.
Not unless we move to C++23, esp-modem is still C++17.
| @@ -0,0 +1,314 @@ | |||
| # ESP Modem Enhanced URC Documentation Plan | |||
Collaborator
There was a problem hiding this comment.
Should we keep this?
Collaborator
Author
There was a problem hiding this comment.
Yes, I'll remove this before merge, it's mentioned above in the TODO list:
Remove AI guided files
| @@ -0,0 +1,439 @@ | |||
| # ESP Modem Enhanced URC Interface Test Plan | |||
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New URC "observer" that controls:
TODO