Skip to content

Fix use of the '!' operator inside the 'in' operator #10

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 29, 2025

Conversation

CodyTolene
Copy link
Contributor

image

@CodyTolene
Copy link
Contributor Author

Just a quick fix up with the PKTYPES check.

Oh also I removed the uart.d.ts file I created from my last push. Let me know if you're interested in including it in your repo, I can create a new PR for it later on.

Thanks!

@gfwilliams
Copy link
Member

Thanks! I don't see a uart.d.ts in the repo (or a removal in this PR).

Right now I'd prefer not to have .ts files as they'll likely just go out of date and I'm not really up on TypeScript enough to reliably maintain them.

@rikkuness has added JSDoc to EspruinoTools (espruino/EspruinoTools#189) and that might be a good thing to add here? so then we can just have a command in package.json that will auto-generate the typescript if needed?

Where possible I prefer to have the function docs in with the function itself so it's easy to check them and keep them up to date.

@gfwilliams gfwilliams merged commit a6a0812 into espruino:master Apr 29, 2025
@rikkuness
Copy link

We can certainly try do something similar here! In the other repo I struggled with these Universal Module Definition type files to get the JSDoc and type generation working properly, but I'm sure it's not impossible, will have a peep 😄

@gfwilliams
Copy link
Member

Thanks! There's no urgency - it was more that if @CodyTolene wanted to add typing, that would be preferable to a separate typescript file

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants