Skip to content

fix: accept day suffix in validityDuration as documented#394

Open
xrl wants to merge 1 commit into
etcd-io:mainfrom
xrl:pr/fix-validity-duration
Open

fix: accept day suffix in validityDuration as documented#394
xrl wants to merge 1 commit into
etcd-io:mainfrom
xrl:pr/fix-validity-duration

Conversation

@xrl

@xrl xrl commented Jul 2, 2026

Copy link
Copy Markdown

Setting validityDuration to the documented day format (e.g. 365d, used by both TLS samples in config/samples) makes reconciliation fail permanently with failed to parse ValidityDuration: time: unknown unit "d" in duration "365d", because parseValidityDuration delegates directly to time.ParseDuration, which does not support the d unit the API doc promises (100d12h). This change expands a leading day segment to hours before parsing, leaving plain Go durations and the empty-string default untouched. Adds table-driven tests for parseValidityDuration covering day-suffix, mixed, plain, default, and invalid inputs.

The API documents validityDuration as a human-readable duration like
"100d12h", and the samples use "365d", but parseValidityDuration
delegated directly to time.ParseDuration which rejects the "d" unit,
so reconciliation failed with 'failed to parse ValidityDuration: time:
unknown unit "d" in duration "365d"'. Expand a leading day segment
to hours before parsing.

Signed-off-by: Xavier Lange <xrlange@gmail.com>
@kubernetes-prow

Copy link
Copy Markdown

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: xrl
Once this PR has been reviewed and has the lgtm label, please assign hakman for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@kubernetes-prow

Copy link
Copy Markdown

Hi @xrl. Thanks for your PR.

I'm waiting for a etcd-io member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work.

Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant