Skip to content

Add bbolt subcommand to etcdutl - #22187

Merged
ahrtr merged 1 commit into
etcd-io:mainfrom
akstron:dev/bbolt-subcommand
Aug 5, 2026
Merged

Add bbolt subcommand to etcdutl#22187
ahrtr merged 1 commit into
etcd-io:mainfrom
akstron:dev/bbolt-subcommand

Conversation

@akstron

@akstron akstron commented Jul 24, 2026 •
edited
Loading

Copy link
Copy Markdown
Contributor

Fixes #15760

@kubernetes-prow

kubernetes-prow Bot commented Jul 24, 2026

Copy link
Copy Markdown

Hi @akstron. Thanks for your PR.

I'm waiting for a etcd-io member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work.

Tip

We noticed you've done this a few times! Consider joining the org to skip this step and gain /lgtm and other bot rights. We recommend asking approvers on your previous PRs to sponsor you.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@akstron
akstron force-pushed the dev/bbolt-subcommand branch from 204161a to d8e57d1 Compare July 24, 2026 17:49
@akstron
akstron force-pushed the dev/bbolt-subcommand branch from d8e57d1 to 1c86665 Compare July 24, 2026 17:54
@kubernetes-prow kubernetes-prow Bot added size/XS and removed size/S labels Jul 24, 2026
@akstron

akstron commented Jul 27, 2026

Copy link
Copy Markdown
Contributor Author

@serathius pinging for review. Let me know if anything else is expected from this issue?

@serathius

serathius commented Jul 27, 2026

Copy link
Copy Markdown
Member

A test would be nice

ahrtr
ahrtr reviewed Jul 27, 2026
View reviewed changes
Comment thread etcdutl/ctl.go Outdated
etcdutl.NewVersionCommand(),
etcdutl.NewCompletionCommand(),
etcdutl.NewMigrateCommand(),
bboltCmd,

@ahrtr ahrtr Jul 27, 2026

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
bboltCmd,
bboltcmd.NewRootCommand(),

@akstron akstron Jul 29, 2026

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Addressed.

Comment thread etcdutl/ctl.go Outdated
Comment on lines +45 to +46
bboltCmd := bboltcmd.NewRootCommand()
bboltCmd.Short = "Low-level bbolt database commands"

@ahrtr ahrtr Jul 27, 2026

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
bboltCmd := bboltcmd.NewRootCommand()
bboltCmd.Short = "Low-level bbolt database commands"

@akstron akstron Jul 29, 2026

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Addressed.

@akstron
akstron force-pushed the dev/bbolt-subcommand branch from 1c86665 to 7bdf5df Compare July 29, 2026 04:33
@kubernetes-prow kubernetes-prow Bot added size/M and removed size/XS labels Jul 29, 2026
@akstron

akstron commented Jul 29, 2026

Copy link
Copy Markdown
Contributor Author

A test would be nice

Added one test to make sure the wiring is correct

@ahrtr

ahrtr commented Jul 29, 2026

Copy link
Copy Markdown
Member

/ok-to-test

ahrtr
ahrtr approved these changes Jul 29, 2026
View reviewed changes

@ahrtr ahrtr left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the contribution.

Please also add a changelog item for etcdutl in 3.8, in this PR or in a separate PR.

@kubernetes-prow

kubernetes-prow Bot commented Jul 29, 2026

Copy link
Copy Markdown

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ahrtr, akstron

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@codecov

codecov Bot commented Jul 29, 2026 •
edited
Loading

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 0% with 1 line in your changes missing coverage. Please review.
✅ Project coverage is 69.72%. Comparing base (3e3b4c1) to head (ba4a3b8).
⚠️ Report is 40 commits behind head on main.

Files with missing lines Patch % Lines
etcdutl/ctl.go 0.00% 1 Missing ⚠️
Additional details and impacted files
Files with missing lines Coverage Δ
etcdutl/ctl.go 0.00% <0.00%> (ø)

... and 24 files with indirect coverage changes

@@            Coverage Diff             @@
##             main   #22187      +/-   ##
==========================================
+ Coverage   69.65%   69.72%   +0.07%     
==========================================
  Files         449      449              
  Lines       38188    38208      +20     
==========================================
+ Hits        26599    26642      +43     
+ Misses      10154    10136      -18     
+ Partials     1435     1430       -5

Continue to review full report in Codecov by Harness.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3e3b4c1...ba4a3b8. Read the comment docs.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@ahrtr

ahrtr commented Jul 29, 2026

Copy link
Copy Markdown
Member

/retest

@akstron
akstron force-pushed the dev/bbolt-subcommand branch from 7bdf5df to aadeefe Compare August 1, 2026 12:04
@akstron

akstron commented Aug 1, 2026

Copy link
Copy Markdown
Contributor Author

Added it @ahrtr . Thanks

@akstron
Add bbolt subcommand to etcdutl
ba4a3b8 
Signed-off-by: Alok Kumar Singh <dev.alok.singh123@gmail.com>
@akstron
akstron force-pushed the dev/bbolt-subcommand branch from aadeefe to ba4a3b8 Compare August 1, 2026 12:07
@akstron

akstron commented Aug 5, 2026

Copy link
Copy Markdown
Contributor Author

@ahrtr can we get this merged?

@ahrtr
ahrtr merged commit 7d7f884 into etcd-io:main Aug 5, 2026
34 checks passed
@marccampbell marccampbell mentioned this pull request Aug 7, 2026
Open
10 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ahrtr ahrtr ahrtr approved these changes

Assignees

No one assigned

Labels

approved area/etcdutl area/testing ok-to-test size/M

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Embed bbolt command as etcdutl subcommand

3 participants

@akstron @serathius @ahrtr