-
Notifications
You must be signed in to change notification settings - Fork 35
Add RocHPL tests #458
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Add RocHPL tests #458
Changes from all commits
Commits
Show all changes
9 commits
Select commit
Hold shift + click to select a range
0f44e1e
Add RocHPL tests
rasolca a87c541
Merge branch 'main' into rochpl
jgphpc ca92095
Apply suggestions from code review
rasolca 89499e4
add bencher tag
rasolca 8f96c5d
Merge branch 'main' into rochpl
jgphpc 1ee61bd
Threshold more permissive.
rasolca 689b067
A bit more permissive
rasolca f028f09
fully permissive
rasolca 590e9e6
readability
jgphpc File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Some comments aren't visible on the classic Files Changed page.
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change | ||||||
|---|---|---|---|---|---|---|---|---|
| @@ -0,0 +1,222 @@ | ||||||||
| # Copyright Swiss National Supercomputing Centre (CSCS/ETH Zurich) | ||||||||
| # ReFrame Project Developers. See the top-level LICENSE file for details. | ||||||||
| # | ||||||||
| # SPDX-License-Identifier: BSD-3-Clause | ||||||||
|
|
||||||||
| import os | ||||||||
| import reframe as rfm | ||||||||
| import reframe.utility.sanity as sn | ||||||||
| from uenv import uarch | ||||||||
|
|
||||||||
| rochpl_references = { | ||||||||
| 'mi200': {38400: 2.65e+04, 192000: 1.49e+05, 218880: 1.55e+05}, | ||||||||
| 'mi300': {38400: 2.53e+04, 192000: 1.57e+05, 218880: 1.62e+05}, | ||||||||
| } | ||||||||
|
|
||||||||
| slurm_config = { | ||||||||
| 'mi200': { | ||||||||
| 'ntasks-per-node': 8, | ||||||||
| 'cpus-per-task': 16, | ||||||||
| }, | ||||||||
| 'mi300': { | ||||||||
| 'ntasks-per-node': 4, | ||||||||
| 'cpus-per-task': 48, | ||||||||
| } | ||||||||
| } | ||||||||
|
|
||||||||
| HPLdat = """HPLinpack benchmark input file | ||||||||
| Innovative Computing Laboratory, University of Tennessee | ||||||||
| HPL.out output file name (if any) | ||||||||
| 0 device out (6=stdout,7=stderr,file) | ||||||||
| {count} # of problems sizes (N) | ||||||||
| {sizes} Ns | ||||||||
| 1 # of NBs | ||||||||
| 384 NBs | ||||||||
| 1 PMAP process mapping (0=Row-,1=Column-major) | ||||||||
| 1 # of process grids (P x Q) | ||||||||
| {p} Ps | ||||||||
| {q} Qs | ||||||||
| 16.0 threshold | ||||||||
| 1 # of panel fact | ||||||||
| 2 PFACTs (0=left, 1=Crout, 2=Right) | ||||||||
| 1 # of recursive stopping criterium | ||||||||
| 8 NBMINs (>= 1) | ||||||||
| 1 # of panels in recursion | ||||||||
| 2 NDIVs | ||||||||
| 1 # of recursive panel fact. | ||||||||
| 2 RFACTs (0=left, 1=Crout, 2=Right) | ||||||||
| 1 # of broadcast | ||||||||
| 6 BCASTs (0=1rg,1=1rM,2=2rg,3=2rM,4=Lng,5=LnM) | ||||||||
| 1 # of lookahead depth | ||||||||
| 1 DEPTHs (>=0) | ||||||||
| 1 SWAP (0=bin-exch,1=long,2=mix) | ||||||||
| 64 swapping threshold | ||||||||
| 1 L1 in (0=transposed,1=no-transposed) form | ||||||||
| 0 U in (0=transposed,1=no-transposed) form | ||||||||
| 0 Equilibration (0=no,1=yes) | ||||||||
| 8 memory alignment in double (> 0) | ||||||||
| """ | ||||||||
|
|
||||||||
|
|
||||||||
| class RocHPL(rfm.RegressionTest): | ||||||||
| descr = 'AMD HPL (rocHPL) test' | ||||||||
| valid_systems = ['+amdgpu +uenv'] | ||||||||
| valid_prog_environs = ['+uenv +prgenv +rocm'] | ||||||||
|
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. @rasolca this should be enough to get HPL into the bencher CI runs:
Suggested change
Contributor
Author
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. I added the tag just for the medium and large test. |
||||||||
| maintainers = ['rasolca', 'SSA'] | ||||||||
| sourcesdir = 'scripts' | ||||||||
| build_system = 'CMake' | ||||||||
| # This branch contains fixes for cmake. | ||||||||
| # https://github.com/ROCm/rocHPL/pull/28 | ||||||||
| prebuild_cmds = [ | ||||||||
| 'git clone --depth 1 --branch cmake_hip ' | ||||||||
| 'https://github.com/rasolca/rocHPL.git' | ||||||||
| ] | ||||||||
| time_limit = '10m' | ||||||||
| build_locally = False | ||||||||
|
|
||||||||
| @run_before('compile') | ||||||||
| def set_build_options(self): | ||||||||
| self.build_system.configuredir = 'rocHPL' | ||||||||
| self.build_system.builddir = 'build' | ||||||||
rasolca marked this conversation as resolved.
Show resolved
Hide resolved
|
||||||||
| self.build_system.max_concurrency = 10 | ||||||||
|
|
||||||||
| gpu_arch = self.current_partition.select_devices('gpu')[0].arch | ||||||||
| self.build_system.config_opts = [ | ||||||||
| '-DHPL_VERBOSE_PRINT=ON', | ||||||||
| '-DHPL_PROGRESS_REPORT=ON', | ||||||||
| '-DHPL_DETAILED_TIMING=ON', | ||||||||
| '-DCMAKE_BUILD_TYPE=Release', | ||||||||
| f'-DCMAKE_HIP_ARCHITECTURES="{gpu_arch}"' | ||||||||
| ] | ||||||||
|
|
||||||||
| @run_after('setup') | ||||||||
| def set_num_gpus(self): | ||||||||
| curr_part = self.current_partition | ||||||||
| self.num_gpus = curr_part.select_devices('gpu')[0].num_devices | ||||||||
|
|
||||||||
| @run_before('run') | ||||||||
| def set_executable(self): | ||||||||
| self.uarch = uarch(self.current_partition) | ||||||||
|
|
||||||||
| pre_script = f'./{self.uarch}-wrapper.sh' | ||||||||
| binary = os.path.join(self.build_system.builddir, 'bin', 'rochpl') | ||||||||
| self.executable = f'{pre_script} {binary}' | ||||||||
|
|
||||||||
| # slurm configuration | ||||||||
| config = slurm_config[self.uarch] | ||||||||
| self.job.options = [f'--nodes=1'] | ||||||||
| self.num_tasks_per_node = config['ntasks-per-node'] | ||||||||
| self.num_tasks = self.num_tasks_per_node | ||||||||
| self.num_cpus_per_task = config['cpus-per-task'] | ||||||||
| self.ntasks_per_core = 2 | ||||||||
| if self.uarch == 'mi200': | ||||||||
| self.job.launcher.options = [( | ||||||||
| '--cpu-bind=mask_cpu:' | ||||||||
| 'ff00000000000000ff000000000000,' | ||||||||
| 'ff00000000000000ff00000000000000,' | ||||||||
| 'ff00000000000000ff0000,' | ||||||||
| 'ff00000000000000ff000000,' | ||||||||
| 'ff00000000000000ff,' | ||||||||
| 'ff00000000000000ff00,' | ||||||||
| 'ff00000000000000ff00000000,' | ||||||||
| 'ff00000000000000ff0000000000')] | ||||||||
| else: | ||||||||
| self.job.launcher.options = ['--cpu-bind=cores'] | ||||||||
|
|
||||||||
| # env variables | ||||||||
| self.env_vars['MPICH_GPU_SUPPORT_ENABLED'] = '1' | ||||||||
| self.env_vars['OMP_PROC_BIND'] = 'true' | ||||||||
| self.env_vars['OMP_NUM_THREADS'] = \ | ||||||||
| f'{self.num_cpus_per_task / self.ntasks_per_core}' | ||||||||
|
|
||||||||
| # executable options | ||||||||
| if self.uarch == 'mi200': | ||||||||
| prows = 2 | ||||||||
| pcols = 4 | ||||||||
| if self.uarch == 'mi300': | ||||||||
| prows = 2 | ||||||||
| pcols = 2 | ||||||||
|
|
||||||||
| input_file = os.path.join(self.stagedir, 'HPL.dat') | ||||||||
| with open(input_file, 'w') as file: | ||||||||
| file.write(HPLdat.format(count=len(self.matrix_sizes), sizes=' '.join(str(n) for n in self.matrix_sizes), p=prows, q=pcols)) # noqa: E501 | ||||||||
|
|
||||||||
| self.executable_opts += [ | ||||||||
| f'-p {prows}', | ||||||||
| f'-q {pcols}', | ||||||||
| f'-P {prows}', | ||||||||
| f'-Q {pcols}', | ||||||||
| f'-i {input_file}' | ||||||||
| ] | ||||||||
|
|
||||||||
| # set performance reference | ||||||||
| if self.uarch in rochpl_references: | ||||||||
| reference = {} | ||||||||
|
|
||||||||
| for n in self.matrix_sizes: | ||||||||
| if n in rochpl_references[self.uarch]: | ||||||||
| # Note: Permissive threshold for mi300 as sles15sp5 shows | ||||||||
| # performance drops with large matrices. Should be removed | ||||||||
| # when all the nodes run the sles15sp6 image. | ||||||||
| lower_bound = -0.1 | ||||||||
| if self.uarch == 'mi300': | ||||||||
| if n > 200000: | ||||||||
| lower_bound = -0.90 | ||||||||
| elif n > 150000: | ||||||||
| lower_bound = -0.33 | ||||||||
|
|
||||||||
| reference[f'size {n}'] = \ | ||||||||
| (rochpl_references[self.uarch][n], | ||||||||
| lower_bound, 0.05, 'Gflop/s') | ||||||||
|
|
||||||||
| self.reference = {self.current_partition.fullname: reference} | ||||||||
|
|
||||||||
| @sanity_function | ||||||||
| def assert_results(self): | ||||||||
| """ | ||||||||
| WC15R2R8 218880 384 2 2 102.52 6.819e+04 | ||||||||
| ||Ax-b||_oo/(eps*(||A||_oo*||x||_oo+||b||_oo)*N)= 0.0000524 ...... PASSED | ||||||||
| """ | ||||||||
| out_file = os.path.join(self.stagedir, 'HPL.out') | ||||||||
|
|
||||||||
| regex1 = r'^WC15R2R8\s+([0-9]+)\s+384\s+[0-9]+\s+[0-9]+\s+[0-9\.]+\s+([0-9\.]+e\+[0-9]+)$' | ||||||||
| regex2 = r'^\|\|Ax-b\|\|_oo\/\(eps\*\(\|\|A\|\|_oo\*\|\|x\|\|_oo\+\|\|b\|\|_oo\)\*N\)=\s+([\.0-9]+)\s+\.+\s+PASSED$' | ||||||||
| self.perf_ = sn.extractall(regex1, out_file, tag=(1, 2), conv=(int, float)) | ||||||||
| self.accuracy_ = sn.extractall(regex2, out_file, tag=1, conv=float) | ||||||||
|
|
||||||||
| sanity_patterns = [ | ||||||||
| sn.assert_eq(sn.len(self.perf_), sn.len(self.matrix_sizes), 'Number of results do not match with number of runs'), | ||||||||
| sn.assert_eq(sn.len(self.accuracy_), sn.len(self.matrix_sizes), 'Number of PASSED accuracy results do not match with number of runs') | ||||||||
| ] | ||||||||
|
|
||||||||
| for (perf, n) in sn.zip(self.perf_, self.matrix_sizes): | ||||||||
| sanity_patterns.append(sn.assert_eq(perf[0], n, 'Matrix size does not match')) | ||||||||
|
|
||||||||
| self.sanity_patterns = sn.all(sanity_patterns) | ||||||||
|
|
||||||||
| return self.sanity_patterns | ||||||||
|
|
||||||||
| @run_before('performance') | ||||||||
| def set_perf_vars(self): | ||||||||
| make_perf = sn.make_performance_function | ||||||||
|
|
||||||||
| self.perf_variables = {} | ||||||||
| for perf in self.perf_: | ||||||||
| self.perf_variables[f'size {perf[0]}'] = make_perf(sn.getitem(perf, 1), 'Gflop/s') | ||||||||
|
|
||||||||
|
|
||||||||
| @rfm.simple_test | ||||||||
rasolca marked this conversation as resolved.
Show resolved
Hide resolved
|
||||||||
| class RocHPL_small(RocHPL): | ||||||||
| matrix_sizes = [38400] | ||||||||
|
|
||||||||
|
|
||||||||
| @rfm.simple_test | ||||||||
rasolca marked this conversation as resolved.
Show resolved
Hide resolved
|
||||||||
| class RocHPL_medium(RocHPL): | ||||||||
| matrix_sizes = [192000] | ||||||||
| tags = {'production', 'uenv', 'bencher'} | ||||||||
|
|
||||||||
|
|
||||||||
| @rfm.simple_test | ||||||||
rasolca marked this conversation as resolved.
Show resolved
Hide resolved
|
||||||||
| class RocHPL_large(RocHPL): | ||||||||
| matrix_sizes = [218880] | ||||||||
| tags = {'production', 'uenv', 'bencher'} | ||||||||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,8 @@ | ||
| #! /usr/bin/env bash | ||
|
|
||
| export GPUID=$(( SLURM_LOCALID % 8)) | ||
|
|
||
| export ROCR_VISIBLE_DEVICES=$GPUID | ||
|
|
||
| "$@" | ||
|
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,8 @@ | ||
| #! /usr/bin/env bash | ||
|
|
||
| export GPUID=$(( SLURM_LOCALID % 4 )) | ||
| export NUMAID=$GPUID | ||
|
|
||
| export ROCR_VISIBLE_DEVICES=$GPUID | ||
|
|
||
| numactl --cpunodebind=$NUMAID --membind=$NUMAID "$@" |
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.