Merge pull request #22 from ethanis/remove-status-check

Remove external status check

README.md

@@ -33,7 +33,7 @@ Add the Nitpicker action to your workflow and allow access to the `secrets.GITHU
 
 ## Blocking comments
 
-A blocking comment indicates that a PR containing changed files that match a specified path filter will be blocked from being completed. After the indicated file/folder has been removed from the PR, the blocking comment will be considered 'resolved' and the PR can be completed.
+A blocking comment indicates that a PR containing changed files that match a specified path filter will fail the build job that the nitpicker is run in. After the indicated file/folder has been removed from the PR, the blocking comment will be considered 'resolved', the build job will succeed, and the PR can be completed.
 
 ## Common use-cases
 

src/main.ts

@@ -5,8 +5,6 @@ import {
   getChangedFiles,
   writeComments,
   getTargetState,
-  startCheck,
-  completeCheck,
   updateComments,
   resolveComments
 } from './services';
@@ -38,16 +36,12 @@ async function run() {
       return;
     }
 
-    const octokit = new github.GitHub(token, {
-      previews: ['squirrel-girl']
-    });
+    const octokit = new github.GitHub(token);
 
     const eventName = process.env.GITHUB_EVENT_NAME;
 
     console.log('starting check');
 
-    const checkRun = await startCheck(octokit);
-
     const changes: Change[] = await getChangedFiles(octokit, eventName);
     const targetState = await getTargetState(octokit, comments, changes);
 
@@ -57,7 +51,11 @@ async function run() {
       resolveComments(octokit, targetState.commentsToResolve)
     ]);
 
-    await completeCheck(octokit, checkRun.id, targetState.conclusion);
+    if (targetState.conclusion !== 'success') {
+      core.setFailed(
+        'nitpicker has failed due to blocking comments being applied'
+      );
+    }
   } catch (error) {
     core.setFailed(error.message);
   }

src/services/index.ts

@@ -1,6 +1,5 @@
 export * from './configReader';
 export * from './comments';
 export * from './changes';
-export * from './checks';
 export * from './context';
 export * from './state';