Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update BXN chain #6871

Open
wants to merge 14 commits into
base: master
Choose a base branch
from
Open

Conversation

BlackFortGroup
Copy link
Contributor

No description provided.

Copy link

You successfully submitted a PR! Due to the amount of PRs coming in: we will only look at PRs that the CI is happy with. We can also not hold your hand getting the CI green - just look how others that where merged did it and RTFM. So as long as there is any CI check that reports an error - no human will look at this. You might be able to ask for some support after supporting the project - e.g. by sending funds to lists.eth. When you fixed things after a requested change - then you also need to (re-)request a review.

Copy link
Member

@ligi ligi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

you cannot delete chains - only mark them deprecated. This is important to prevent replay attacks

@BlackFortGroup
Copy link
Contributor Author

Hello, @ligi! Could you tell us how to avoid issue with the latest build? We're not supporting chains 4777 and 4999 anymore and we've moved to a new one with new id, but same name. Both 4777 and 4999 are now marked as deprecated

Thank you

@BlackFortGroup
Copy link
Contributor Author

Hello @ligi, our updated chains remain same symbol name, that's the reason of failing build. Could you assist us?

@BlackFortGroup BlackFortGroup requested a review from ligi February 27, 2025 07:16
Copy link
Member

@ligi ligi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

short name must be unique - but found BXN more than once

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants