-
Notifications
You must be signed in to change notification settings - Fork 238
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add public key schema to prisma #785
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
examples/bri-3/prisma/migrations/20240124083845_add_public_key_to_bpi_subject/migration.sql
Outdated
Show resolved
Hide resolved
examples/bri-3/prisma/migrations/20240124083845_add_public_key_to_bpi_subject/migration.sql
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@biscuitdey left some comments to be addressed.
examples/bri-3/prisma/migrations/20240124083845_add_public_key_to_bpi_subject/migration.sql
Outdated
Show resolved
Hide resolved
examples/bri-3/src/bri/identity/bpiSubjects/agents/bpiSubjectsStorage.agent.ts
Outdated
Show resolved
Hide resolved
examples/bri-3/src/bri/identity/bpiSubjects/agents/bpiSubjectsStorage.agent.ts
Outdated
Show resolved
Hide resolved
…ture/759-create-public-key-schema
ognjenkurtic
reviewed
Feb 2, 2024
examples/bri-3/prisma/migrations/20240201082211_add_key_type_enum_to_public_key/migration.sql
Outdated
Show resolved
Hide resolved
ognjenkurtic
reviewed
Feb 2, 2024
examples/bri-3/prisma/migrations/20240201082211_add_key_type_enum_to_public_key/migration.sql
Outdated
Show resolved
Hide resolved
examples/bri-3/src/bri/identity/bpiSubjects/models/bpiSubject.ts
Outdated
Show resolved
Hide resolved
examples/bri-3/src/bri/identity/bpiSubjects/models/bpiSubject.ts
Outdated
Show resolved
Hide resolved
Therecanbeonlyone1969
approved these changes
Feb 14, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
ognjenkurtic
approved these changes
Feb 28, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR adds the public key schema to prisma
Related Issue
#759
Motivation and Context
To allow us to add different types of keys
How Has This Been Tested
Will update code in upcoming PR to pass tests.
Types of changes
Checklist