op-devstack: contract call DSL interface + impl PoC #16002
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pcw109550
changed the title
pcw109550
changed the title
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #16002 +/- ##
============================================
- Coverage 46.87% 0 -46.88%
============================================
Files 1345 0 -1345
Lines 108609 0 -108609
============================================
- Hits 50914 0 -50914
+ Misses 54080 0 -54080
+ Partials 3615 0 -3615
Flags with carried forward coverage won't be shown. Click here to find out more. 🚀 New features to boost your workflow:
|
|
Closing. using #16046 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
DSL PoC using
Callinterface, implementing basicCallinterface and simple implementation (WETH).Note that this is a PoC implementation and definitely needs a clean up.
Tests
Added
TestCallViewWriteWETH, which is a superset ofTestSystemWrapETHathttps://github.com/ethereum-optimism/optimism/blob/develop/op-acceptance-tests/tests/interop/interop_smoke_test.go#L53C6-L53C23. The original
TestSystemWrapETHwas written using the legacy bindings and not using devstack. ThisTestCallViewWriteWETHattempts to rewrite using op-devstack with a poc of contract call DSL.Additional context
Note that there are bunch of TODOs. For PoCing I used w3 but this is desired to be isolated and abstracted using tools like abigenv2.
Metadata
Callinterface using WETH #16001