Skip to content

Gas validation: Add an exception for Base #801

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Dec 17, 2024
Merged

Gas validation: Add an exception for Base #801

merged 2 commits into from
Dec 17, 2024

Conversation

vdamle
Copy link
Contributor

@vdamle vdamle commented Dec 17, 2024

As noted in issue#800, we are adding an exception for the gas validation check for Base with an explicit directive for it to be removed when Base adheres to the standard charter.

Adding a New Chain

N/A

Checklist

  • I have declared the chain at the appropriate Superchain Level.
  • I have run just validate <chain-id> locally to ensure all local validation checks pass.
  • I have run just codegen to ensure that the chainlist and other generated files are up-to-date and include my chain.

Ref: #800

@vdamle vdamle requested review from geoknee and bitwiseguy December 17, 2024 00:10
@vdamle vdamle requested a review from a team as a code owner December 17, 2024 00:10
@bitwiseguy
Copy link
Collaborator

Could we move the exception here instead? Its nice to have a central place for all exceptions/exclusions

@vdamle
Copy link
Contributor Author

vdamle commented Dec 17, 2024

Could we move the exception here instead? Its nice to have a central place for all exceptions/exclusions

Thanks @bitwiseguy . Updated now

As noted in issue#800, we are adding an exception for the gas validation check
for Base with an explicit directive for it to be removed when Base adheres to the
standard charter.
@bitwiseguy bitwiseguy added this pull request to the merge queue Dec 17, 2024
Merged via the queue into main with commit 2db4509 Dec 17, 2024
14 checks passed
@bitwiseguy bitwiseguy deleted the issue-800 branch December 17, 2024 15:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants