This repository was archived by the owner on Oct 28, 2021. It is now read-only.
evm: Change Executive::m_gas to int64_t #5317
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gumb0
reviewed
Oct 16, 2018
| /// The amount of gas for EVM execution. | ||
| /// | ||
| /// Initial amount before go() execution, the amount of gas left after go() execution. | ||
| int64_t m_gas = 0; |
There was a problem hiding this comment.
So what is the advantage of using signed instead of unsigned here?
There was a problem hiding this comment.
|
Some SSTORE tests need updating |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A small follow up for #5316.
A lot more changes like that can be made. If I have time I can push more to this branch. So for, please review.