This repository was archived by the owner on Oct 28, 2021. It is now read-only.
Pass options to EVMC class constructor instead of using globally set options #5875
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #5875 +/- ##
==========================================
- Coverage 63.96% 63.93% -0.04%
==========================================
Files 365 365
Lines 31093 31098 +5
Branches 3441 3441
==========================================
- Hits 19890 19882 -8
- Misses 9972 9980 +8
- Partials 1231 1236 +5 |
chfast
approved these changes
Dec 23, 2019
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a preparation for #5855 where
EVMCclass is used not only for EVM, but also for precompiles, and EVMC options from command line shouldn't be set to precompiles VM.