This repository was archived by the owner on Oct 28, 2021. It is now read-only.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addresses #5889
TODO
BlockChain::forkHash()BlockChain::m_paramshas all the known fork block numbers. Fork block number =c_infiniteBlockNumbermeans it's disabled; fork block number =0means it's activated at genesis.try to just
#include <cryptopp/crc.h>but better to create a wrapper for it in ourlibdevcryptoBlockChain::nextForkBlockNumber()ethfield to ENR - easiest would be to add it toIdentitySchemeV4::updateENRandIdentitySchemeV4::createKeyValuePairsNodeTabletoIdentitySchemeV4::updateENRcc @fjl