refactor(ethereum_clis): move TransitionTool.verify_fixture()
to StateTest
and BlockTest
#935
+398
−247
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🗒️ Description
This PR refactors
ethereum_clis
and theconsume direct
interface so that it can be extended to other clients.Previously, the
GethTransitionTool
class implemented fixture consumption and referred to it as "fixture verification". The reason is historical: the first "consumer" was implemented infill
.This PR:
GethStatetest
andGethBlocktest
interface consumer classes to theevm statetest
, respectivelyevm_blocktest
commands.GethFixtureConsumer
class which applies the appropriate consumer class for the fixture to run against the client.Note, that as we now instantiate the
GethStatetest
andGethBlocktest
classes from withinGethFixtureConsumer
we don't currently use any of the binary detection/automatic subclass instantiation provided byEthereumCLI
that is used for theTransitionTool
.🔗 Related Issues
None.
✅ Checklist