Skip to content

Conversation

@pdobacz
Copy link
Contributor

@pdobacz pdobacz commented Nov 4, 2025

πŸ—’οΈ Description

One more test for header validation coverage, this time specific to withdrawals, so added to Shanghai tests.

πŸ”— Related Issues or PRs

N/A.

βœ… Checklist

  • All: Ran fast tox checks to avoid unnecessary CI fails, see also Code Standards and Enabling Pre-commit Checks:
    uvx tox -e static
  • All: PR title adheres to the repo standard - it will be used as the squash commit message and should start type(scope):.
  • All: Considered adding an entry to CHANGELOG.md.
  • All: Set appropriate labels for the changes (only maintainers can apply labels).

chetna-mittal pushed a commit to gnosischain/execution-specs that referenced this pull request Nov 8, 2025
Copy link
Member

@marioevz marioevz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@marioevz marioevz merged commit cb01c39 into ethereum:forks/osaka Nov 27, 2025
12 checks passed
@codecov
Copy link

codecov bot commented Nov 27, 2025

Codecov Report

βœ… All modified and coverable lines are covered by tests.
βœ… Project coverage is 86.08%. Comparing base (fa1a2bb) to head (5734e73).
⚠️ Report is 16 commits behind head on forks/osaka.

Additional details and impacted files
@@               Coverage Diff               @@
##           forks/osaka    #1746      +/-   ##
===============================================
- Coverage        86.08%   86.08%   -0.01%     
===============================================
  Files              743      743              
  Lines            44072    44076       +4     
  Branches          3891     3891              
===============================================
+ Hits             37938    37941       +3     
- Misses            5656     5657       +1     
  Partials           478      478              
Flag Coverage Ξ”
unittests 86.08% <ΓΈ> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

β˜” View full report in Codecov by Sentry.
πŸ“’ Have feedback on the report? Share it here.

πŸš€ New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • πŸ“¦ JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@pdobacz pdobacz deleted the tests/withdrawals branch November 28, 2025 17:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants