Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for instructions and source ranges. #15368

Draft
wants to merge 2 commits into
base: enable_debug_info_ethdebug
Choose a base branch
from

Conversation

aarlt
Copy link
Member

@aarlt aarlt commented Aug 28, 2024

No description provided.

@aarlt aarlt added the ethdebug label Aug 28, 2024
@aarlt aarlt force-pushed the ethdebug_instructions_and_source_ranges branch 2 times, most recently from 82e0668 to 51b69fc Compare August 29, 2024 00:50
@ethereum ethereum deleted a comment from stackenbotten Aug 29, 2024
@aarlt aarlt force-pushed the ethdebug_instructions_and_source_ranges branch 2 times, most recently from ce130c1 to feda85c Compare August 30, 2024 12:59
@aarlt aarlt force-pushed the enable_debug_info_ethdebug branch from 93749ff to 0dd51e5 Compare August 30, 2024 14:54
@aarlt aarlt force-pushed the ethdebug_instructions_and_source_ranges branch from feda85c to fd1bb3a Compare August 30, 2024 15:06
@aarlt aarlt force-pushed the enable_debug_info_ethdebug branch 6 times, most recently from 32b21f6 to fe6a4ca Compare September 24, 2024 15:51
Comment on lines 430 to 431
util::LazyInit<Json const> ethdebug;
util::LazyInit<Json const> ethdebugRuntime;
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please not. Even storing Yul ASTs was making memory usage go through the roof and giving us a 25% performance hit. And I expect that the whole ethdebug dump will be much bigger than the AST...

See #15451 (comment).

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yeah I saw that and I agree that this might get quite bad with the ethdebug stuff..

@aarlt aarlt force-pushed the enable_debug_info_ethdebug branch 6 times, most recently from c885a10 to c4faae4 Compare October 7, 2024 10:56
@aarlt aarlt force-pushed the ethdebug_instructions_and_source_ranges branch from fd1bb3a to f3205fa Compare October 7, 2024 20:32
@aarlt aarlt force-pushed the enable_debug_info_ethdebug branch from c4faae4 to c9417ed Compare October 8, 2024 10:32
@aarlt aarlt force-pushed the ethdebug_instructions_and_source_ranges branch from f3205fa to 3cfe207 Compare October 8, 2024 10:51
@aarlt aarlt force-pushed the enable_debug_info_ethdebug branch 4 times, most recently from ada3616 to 6b2efa0 Compare October 16, 2024 12:18
Copy link

This pull request is stale because it has been open for 14 days with no activity.
It will be closed in 7 days unless the stale label is removed.

@github-actions github-actions bot added the stale The issue/PR was marked as stale because it has been open for too long. label Nov 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ethdebug stale The issue/PR was marked as stale because it has been open for too long.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants