Update release checklist: homebrew and solc-js instructions #15494
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
r0qs
reviewed
Oct 9, 2024
r0qs
force-pushed
the
update-release-checklist-for-8-28
branch
from
ac5dc6b
to
fe43d53
Compare
r0qs
force-pushed
the
update-release-checklist-for-8-28
branch
from
514c9f9
to
e42906b
Compare
cameel
reviewed
Oct 11, 2024
Comment on lines
+80
to
+84
| - [ ] Make sure that ``brew`` is installed on your system, or use the official Homebrew docker container: | ||
| ``docker run --interactive --tty --rm --pull always --volume "$(pwd):/homebrew-core" --workdir "/homebrew-core" homebrew/ubuntu22.04:latest /bin/bash`` | ||
| #### Manual Update | ||
| - [ ] Open the [``solidity`` formula in Homebrew core repository](https://github.com/Homebrew/homebrew-core/blob/master/Formula/s/solidity.rb) using your preferred text editor and update the following fields: | ||
| - url: Update the URL to reflect the new source file for the updated version. |
There was a problem hiding this comment.
Spacing and indentation is off here:
Suggested change
| - [ ] Make sure that ``brew`` is installed on your system, or use the official Homebrew docker container: | |
| ``docker run --interactive --tty --rm --pull always --volume "$(pwd):/homebrew-core" --workdir "/homebrew-core" homebrew/ubuntu22.04:latest /bin/bash`` | |
| #### Manual Update | |
| - [ ] Open the [``solidity`` formula in Homebrew core repository](https://github.com/Homebrew/homebrew-core/blob/master/Formula/s/solidity.rb) using your preferred text editor and update the following fields: | |
| - url: Update the URL to reflect the new source file for the updated version. | |
| - [ ] Make sure that ``brew`` is installed on your system, or use the official Homebrew docker container: | |
| ``docker run --interactive --tty --rm --pull always --volume "$(pwd):/homebrew-core" --workdir "/homebrew-core" homebrew/ubuntu22.04:latest /bin/bash`` | |
| #### Manual Update | |
| - [ ] Open the [``solidity`` formula in Homebrew core repository](https://github.com/Homebrew/homebrew-core/blob/master/Formula/s/solidity.rb) using your preferred text editor and update the following fields: | |
| - url: Update the URL to reflect the new source file for the updated version. |
| - [ ] Update the version and the hash (``sha256sum solidity_$VERSION.tar.gz``) in the [``solidity`` formula in Homebrew core repository](https://github.com/Homebrew/homebrew-core/blob/master/Formula/solidity.rb). | ||
| - [ ] Create a local fork of the repository at ``[email protected]:Homebrew/homebrew-core.git`` | ||
| - [ ] Make sure that ``brew`` is installed on your system, or use the official Homebrew docker container: | ||
| ``docker run --interactive --tty --rm --pull always --volume "$(pwd):/homebrew-core" --workdir "/homebrew-core" homebrew/ubuntu22.04:latest /bin/bash`` |
There was a problem hiding this comment.
Suggested change
| ``docker run --interactive --tty --rm --pull always --volume "$(pwd):/homebrew-core" --workdir "/homebrew-core" homebrew/ubuntu22.04:latest /bin/bash`` | |
| ``docker run --interactive --tty --rm --pull always --volume "$PWD:/homebrew-core" --workdir /homebrew-core homebrew/ubuntu22.04`` |
Comment on lines
+84
to
+85
| - url: Update the URL to reflect the new source file for the updated version. | ||
| - sha256: Replace with the new SHA256 checksum of the source file. You can obtain it using a command like: |
There was a problem hiding this comment.
Suggested change
| - url: Update the URL to reflect the new source file for the updated version. | |
| - sha256: Replace with the new SHA256 checksum of the source file. You can obtain it using a command like: | |
| - ``url``: Update the URL to reflect the new source file for the updated version. | |
| - ``sha256``: Replace with the new SHA256 checksum of the source file. You can obtain it using a command like: |
Comment on lines
+91
to
+92
| - [ ] Run the following command to automatically update the formula and create a PR in the Homebrew repository: ``brew bump-formula-pr --version=$VERSION solidity`` | ||
| Note: the version should not include the prefix ``v``, e.g. ``X.Y.Z``. |
There was a problem hiding this comment.
Suggested change
| - [ ] Run the following command to automatically update the formula and create a PR in the Homebrew repository: ``brew bump-formula-pr --version=$VERSION solidity`` | |
| Note: the version should not include the prefix ``v``, e.g. ``X.Y.Z``. | |
| - [ ] Run the following command to automatically update the formula and create a PR in the Homebrew repository: ``brew bump-formula-pr --version=$VERSION solidity``. | |
| Note: the version should not include the ``v`` prefix, i.e. ``X.Y.Z``. |
| @@ -103,6 +116,7 @@ At least a day before the release: | |||
| - [ ] Wait for the CI runs on the tag itself. | |||
| - [ ] Take the ``solc-x.y.z.tgz`` artifact from ``build-package`` run on the tagged commit in circle-ci. | |||
| Inspect the tarball to ensure that it contains an up-to-date compiler binary (``soljson.js``). | |||
| See the section "Testing version of soljson.js": https://github.com/ethereum/solidity/wiki/Building-solc%E2%80%90js-from-source#testing-version-of-soljsonjs | |||
There was a problem hiding this comment.
Suggested change
| See the section "Testing version of soljson.js": https://github.com/ethereum/solidity/wiki/Building-solc%E2%80%90js-from-source#testing-version-of-soljsonjs | |
| See the [Testing version of soljson.js](https://github.com/ethereum/solidity/wiki/Building-solc‐js-from-source#testing-version-of-soljsonjs) section on the wiki. |
cameel
changed the title
|
This pull request is stale because it has been open for 14 days with no activity. |
github-actions
bot
added
the
stale
|
This pull request was closed due to a lack of activity for 7 days after it was stale. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.