Disallow non-default expectedExecutionsPerDeployment
in evmasm tests when only a creation object is present
#16023
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Depends on #16021.
This adds an extra check to prevent confusion like in #16012 (comment).
expectedExecutionsPerDeployment
only affects runtime assemblies, but the top-level assembly is a creation one so if you have only one, it will seem like the setting is not working. This PR makes the test case throw an exception in that situation to make it obvious. It is not likely to be intentional.I did not include it in #16021, because I'm not yet 100% convinced we want this. There are some downsides:
--import-asm-json
would just accept it.Still, these seem minor enough that we're probably better off with this check than without it.