-
Notifications
You must be signed in to change notification settings - Fork 397
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implement a storage service to upload contracts on S3 #1728
base: staging
Are you sure you want to change the base?
Conversation
Haven't looked yet but IMO we should name it to |
I already called it like this in the code but forgot to update the description, I had the same thought yesterday :D |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great solution to our problem with the s3 sync script :)
I only have a few minor comments.
services/server/src/server/services/storageServices/S3RepositoryService.ts
Outdated
Show resolved
Hide resolved
services/server/src/server/services/storageServices/S3RepositoryService.ts
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
This PR implements an S3-based storage service. The service allows uploading verified contract files to an S3 bucket while maintaining the same directory structure as RepositoryV2.
S3RepositoryService
class that implements the storage interfaceS3RepositoryService
is an extension ofRepositoryV2
, in which the write/delete/get file functions are overridden: instead of editing a fs, it's calling the AWS SDK APIs.TODO: