Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade contract private endpoint #2018

Conversation

marcocastignoli
Copy link
Member

This PR adds a new private endpoint that we'll use to fix #1974, this endpoint calls the upgradeContract handler that:

  • extract compilation and onchain information from the database
  • initialize Compilation and Verification with the extracted data, overriding getter functions
  • disable unwanted Compilation methods, such as Compilation.compile() and Compilation.generateCborAuxdataPositions(), we already have in the database all the needed information
  • mock SourcifyChain methods so that it returns onchain information without calling the RPC
  • calls Verification.verify() to regenerate transformations
  • updates misaligned columns in verified_contracts and sourcify_matches

@manuelwedler
Copy link
Contributor

I'm still not sure if we should run this inside the server. We could also just run this as a script in GCP.

@marcocastignoli
Copy link
Member Author

@kuzdogan can I have a feedback also from you? Also, what do you think of Manu's comment?

I'm still not sure if we should run this inside the server. We could also just run this as a script in GCP.

@marcocastignoli marcocastignoli self-assigned this Mar 27, 2025
@marcocastignoli
Copy link
Member Author

Closed in favor of #2042

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: COMPLETED
Development

Successfully merging this pull request may close these issues.

2 participants