Symbol.iterator for Result #13
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It'd be very convenient to be able to pull values out of Results via array destructuring.
|
Looks like the webpack build failed. Does the UglifyJs plugin have something against generator function syntax? 🤔 |
|
Possibly, I'm taking a week off, be back on the 13th.
This could be interesting!
…Sent from my iPhone
On Nov 8, 2017, at 4:57 PM, Josiah Savary ***@***.***> wrote:
Looks like the webpack build failed. Does the UglifyJs plugin have something against generator function syntax? 🤔
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub, or mute the thread.
|
|
Enjoy your break! |
|
@jozanza can you look into another dev environment that would support your changes? Maybe switching out uglify JS, or looking into that more closely. |
Added an plain object iterator to avoid minifier issues
|
@SilentCicero hey sorry for the delay. I updated the PR to use a non-generator iterator, so we shouldn't have to mess with the environment. Now, I just need to add a test to get coverage back up. |
|
@jozanza highly desired feature - seems like it needs some test coverage |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added the
Symbol.iteratormethod to instances ofResult. If everyone's into it, I can write a couple test cases to keep coverage at 100%. Once merged, this would close #12.