add a basic benchmark, optimize it by ~50%#7
Merged
stephanemagnenat merged 2 commits intoethz-gtc:mainfrom Mar 31, 2025
Merged
Conversation
Before change:
mcts_run time: [7.0371 ms 7.0612 ms 7.0870 ms]
change: [-0.4500% -0.0008% +0.4727%] (p = 1.00 > 0.05)
No change in performance detected.
Found 1 outliers among 100 measurements (1.00%)
1 (1.00%) high mild
After change:
Changed hasher after looking at profiling:
mcts_run time: [3.8360 ms 3.8503 ms 3.8650 ms]
change: [-45.754% -45.473% -45.199%] (p = 0.00 < 0.05)
Performance has improved.
Found 1 outliers among 100 measurements (1.00%)
1 (1.00%) high mild
Contributor
|
lgtm |
Contributor
|
Oups, I didn't see the linter issues. @haydenflinner do you have bandwidth to fix the linter issues and submit a PR with the changes? Thank you! |
Contributor
|
Never mind, I fixed the clippy issues. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.