[ga] Add test for macos-14 and macos-15 (Apple Silicon)#648
Closed
iory wants to merge 5 commits intoeuslisp:masterfrom
Closed
[ga] Add test for macos-14 and macos-15 (Apple Silicon)#648iory wants to merge 5 commits intoeuslisp:masterfrom
iory wants to merge 5 commits intoeuslisp:masterfrom
Conversation
There was a problem hiding this comment.
Pull Request Overview
This PR extends the macOS CI matrix to include Apple Silicon on macOS 14 and 15 and updates the cache action to v4.
- Add a matrix strategy for macOS jobs targeting Intel (macos-13) and ARM64 (macos-14, macos-15)
- Upgrade
actions/cachefrom v2 to v4
Comments suppressed due to low confidence (2)
.github/workflows/config.yml:207
- The
::set-outputcommand is deprecated; migrate to the new output syntax by appending to the$GITHUB_OUTPUTfile, e.g.,echo "dir=$(brew --cache)/downloads" >> $GITHUB_OUTPUT.
run: echo "::set-output name=dir::$(brew --cache)/downloads"
.github/workflows/config.yml:209
- [nitpick] Consider adding a
restore-keysentry to this cache step to provide fallback keys and improve cache hit rates when the primary key misses.
uses: actions/cache@v4
k-okada
requested changes
Jul 2, 2025
Member
k-okada
left a comment
k-okada
left a comment
There was a problem hiding this comment.
please merge catkin -fix commit from #649
https://github.com/iory/jskeus/compare/iory:apple-silicon-test...iory:fix-catkin?expand=1
Contributor
Author
|
Thank you for your review. |
Contributor
Author
|
Closed by #647 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related to euslisp/EusLisp#529
This PR enables tests for
macos-14andmacos-15(apple-silicon).This test is expected to fail on
macos-14andmacos-15.The following PR (#647) applies a patch to make the test pass on
macos-14andmacos-15.