Tariff templates: add provider links - #32012
Merged
Merged
Conversation
andig
added
enhancement
Member
Author
|
@naltatis wdyt? Not convinced we absolutely need this but it may be a nice touch. Limited the experiment to tariffs. Instead of the base brand link these could be made more useful by targeting the actual upstream integration page. |
Member
|
We should link to the actual products/services/tariffs we are integrating here, not only the homepage. Especially important for sites with a broad portfolio (e.g. victron). I'll go through and update the links. |
Member
|
Now linking to the actual service/product if the vendor offers more than one. |
naltatis
marked this pull request as ready for review
July 29, 2026 16:17
naltatis
approved these changes
Jul 29, 2026
Member
|
Added link-selection guidance here https://github.com/evcc-io/evcc/pull/32008/changes#diff-af03ff89b349afdbf776d0d586c7d37ce78adeaf36f3340d9a429d5cbb5de860R55 |
naltatis
approved these changes
Aug 5, 2026
![sourcery-ai[bot]](https://avatars.githubusercontent.com/in/48477?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Hey - I've found 1 issue
Prompt for AI Agents
Please address the comments from this code review:
## Individual Comments
### Comment 1
<location path="templates/definition/tariff/energypriceforecast.yaml" line_range="2" />
<code_context>
template: energypriceforecast-co2
+link: https://energypriceforecast.eu/en/evcc-electricity-price-co2-forecast/
products:
- brand: Energy Price Forecast EU
</code_context>
<issue_to_address>
**question:** Consider whether the non-CO₂ template should link to a more generic product page instead of the CO₂-specific one.
Since both `energypriceforecast.yaml` and `energypriceforecast-co2.yaml` use this CO₂-specific URL, please confirm whether this template is intended for the CO₂ product only. If it’s meant for a more general or non-CO₂ tariff, consider switching to a neutral landing or documentation page so the mapping between template and product is unambiguous.
</issue_to_address>Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-up to #32008: populates the new
linkproperty for tariff templates.linkto the vendor or data provider🤖 Generated with Claude Code