UI: fix loadpoint value alignment on narrow screens (#31993) - #32050
Draft
jenskueper wants to merge 1 commit into
Draft
UI: fix loadpoint value alignment on narrow screens (#31993)#32050jenskueper wants to merge 1 commit into
jenskueper wants to merge 1 commit into
Conversation
Contributor
There was a problem hiding this comment.
Hey - I've left some high level feedback:
- The
.labelSelectclass name is a bit generic; consider a more descriptive name tied to the session info context to reduce ambiguity and future misuse. - The
vertical-align: top !important;rule may be hard to override later; if possible, prefer adjusting the CustomSelect or utility classes to avoid relying on!important.
Prompt for AI Agents
Please address the comments from this code review:
## Overall Comments
- The `.labelSelect` class name is a bit generic; consider a more descriptive name tied to the session info context to reduce ambiguity and future misuse.
- The `vertical-align: top !important;` rule may be hard to override later; if possible, prefer adjusting the CustomSelect or utility classes to avoid relying on `!important`.Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.
andig
reviewed
Jul 22, 2026
| user-select: none; | ||
| -webkit-user-select: none; | ||
| } | ||
| /* Truncation (overflow: hidden via .text-truncate-xs-only) moves the baseline of the |
andig
marked this pull request as draft
July 22, 2026 15:02
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #31993. On viewports below the sm breakpoint, .text-truncate-xs-only applies overflow: hidden to the label inside the session-info select on the loadpoint card.
Because a scroll container has no text baseline, the baseline of the surrounding inline-block select falls back to its bottom edge, which grows the label's line box and pushes the session value a few pixels below the other loadpoint values (power, charged energy). This happens at the same breakpoint where the loadpoint header wraps onto two lines, which is why the two effects appear linked. Top-aligning the select inside the label keeps the line box at its normal height, so all values stay on one line; rendering at larger viewports is unchanged.