EEBus: accept an inactive §14a limit without a value - #32155
Merged
Conversation
Contributor
There was a problem hiding this comment.
Hey - I've left some high level feedback:
- The temporary
replace github.com/enbility/eebus-go => github.com/andig/eebus-go ...in go.mod would benefit from an inline TODO or comment referencing the upstream PR/issue to make it clear when and under what conditions this should be reverted.
Prompt for AI Agents
Please address the comments from this code review:
## Overall Comments
- The temporary `replace github.com/enbility/eebus-go => github.com/andig/eebus-go ...` in go.mod would benefit from an inline TODO or comment referencing the upstream PR/issue to make it clear when and under what conditions this should be reverted.Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Addresses the
dimmed: not availablehalf of #32125.A Wolf Link heat pump announces
limitationOfPowerConsumptionwithscenarioSupport [1,2,3,4]and answers the limit read with{"loadControlLimitData":[[{"limitId":1},{"isLimitChangeable":true},{"isLimitActive":false}]]}No limit is in effect, so no value is stated. eebus-go discarded the whole structure on the missing value and returned
ErrDataNotAvailable, whichDimmed()maps toapi.ErrNotAvailable— so evcc could not tell "no §14a limit active" from "no data at all", and the loadpoint aborted every update cycle.Fixed upstream in enbility/eebus-go#255: an inactive limit may omit its value, an active one may not. Same change in
eg/lpc,eg/lpp,cs/lpcandcs/lpp. Until that is merged the module points at the branch viareplace.This is the root cause behind #32126, which suppressed the error in
Loadpoint.Update()instead.🤖 Generated with Claude Code