Skip to content

EEBus: accept an inactive §14a limit without a value - #32155

Merged
andig merged 1 commit into
masterfrom
fix/eebus-inactive-limit
Jul 25, 2026
Merged

EEBus: accept an inactive §14a limit without a value#32155
andig merged 1 commit into
masterfrom
fix/eebus-inactive-limit

Conversation

@andig

@andig andig commented Jul 25, 2026

Copy link
Copy Markdown
Member

Addresses the dimmed: not available half of #32125.

A Wolf Link heat pump announces limitationOfPowerConsumption with scenarioSupport [1,2,3,4] and answers the limit read with

{"loadControlLimitData":[[{"limitId":1},{"isLimitChangeable":true},{"isLimitActive":false}]]}

No limit is in effect, so no value is stated. eebus-go discarded the whole structure on the missing value and returned ErrDataNotAvailable, which Dimmed() maps to api.ErrNotAvailable — so evcc could not tell "no §14a limit active" from "no data at all", and the loadpoint aborted every update cycle.

Fixed upstream in enbility/eebus-go#255: an inactive limit may omit its value, an active one may not. Same change in eg/lpc, eg/lpp, cs/lpc and cs/lpp. Until that is merged the module points at the branch via replace.

This is the root cause behind #32126, which suppressed the error in Loadpoint.Update() instead.


🤖 Generated with Claude Code

@andig andig added bug Something isn't working devices Specific device support labels Jul 25, 2026
@github-actions github-actions Bot added the heating Heating label Jul 25, 2026

@sourcery-ai sourcery-ai Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey - I've left some high level feedback:

  • The temporary replace github.com/enbility/eebus-go => github.com/andig/eebus-go ... in go.mod would benefit from an inline TODO or comment referencing the upstream PR/issue to make it clear when and under what conditions this should be reverted.
Prompt for AI Agents
Please address the comments from this code review:

## Overall Comments
- The temporary `replace github.com/enbility/eebus-go => github.com/andig/eebus-go ...` in go.mod would benefit from an inline TODO or comment referencing the upstream PR/issue to make it clear when and under what conditions this should be reverted.

Sourcery is free for open source - if you like our reviews please consider sharing them ✨
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.

@andig
andig merged commit 408f9a0 into master Jul 25, 2026
11 checks passed
@andig
andig deleted the fix/eebus-inactive-limit branch July 25, 2026 16:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working devices Specific device support heating Heating

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant