Forecast solar chart: fix duplicate Y-axis labels for small PV systems - #33307
Draft
github-actions[bot] wants to merge 1 commit into
Draft
Forecast solar chart: fix duplicate Y-axis labels for small PV systems#33307github-actions[bot] wants to merge 1 commit into
github-actions[bot] wants to merge 1 commit into
Conversation
The axis label formatter always converted to kW with 0 decimals, so for a peak forecast under 1 kW every tick rounded to "0". Switch to W below a 1 kW peak, mirroring the same threshold already used in GroupChart.vue.
2 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fixes #33306
The Y-axis label formatter in the forecast solar chart always converted values to kW with 0 decimal digits. For systems with a peak forecast well under 1 kW (e.g. balcony PV), every tick (0, mid, max) rounds to "0 kW", making the axis meaningless.
Fix: switch the axis label unit to W when the combined forecast peak (
combinedMax) is below 1000 W, mirroring the same< 1 kWthreshold already used for the same purpose inGroupChart.vue.assets/js/components/Forecast/SolarChart.vue🤖 Generated with Claude Code