Fixed graceful disposal on SIGTERM shutdown in message processors - #306
Merged
oskardudycz merged 2 commits intoFeb 23, 2026
Merged
Conversation
The processor's shutdown handler was calling close({}) instead of
close(startOptions), losing the connection context. This caused
postgreSQLProcessingScope to throw "missing connection string" when
a processor was terminated via SIGTERM.
Collaborator
|
@Bazze, I think there's something odd happening in the PostgreSQL processor as well. The processor shouldn't require those options; it should just clean up what it has active. As this is fixing the issue for now, I'm going to merge it and later try to improve it. Thanks a lot for doing that. 👍 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I discovered something that I think is a bug (?). The processor's shutdown handler was calling close({}) instead of close(startOptions), losing the connection context. This caused
postgreSQLProcessingScopeto throw "missing connection string" when a processor was terminated via SIGTERM.I had below error when my local docker container restarted on file changes.