feat(server): add force inclusion cmd #295
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
11 tasks
github-merge-queue bot
pushed a commit
to evstack/ev-node
that referenced
this pull request
Dec 3, 2025
ref: #1914 A choice has been made to make this logic in the executor and avoid extending the reaper and the sequencer. This is because, updating the repeer, means passing down the last fetched da height accross all components. It adds a lot of complexity otherwise. Adding it in the sequencer may be preferable, but this makes the inclusion in a sync node less straightforward. This is what is being investigated. Compared to the previous implementation, a forced transaction does not have any structure. It should be the raw structure from the execution client. This is to keep ev-node know nothing about the transaction. No signature checks, no validation of correctness. The execution client must make sure to reject gibberish transactions. - [x] implement for executor - [x] add size checks, to make sure batch doesn't go over max bytes - [x] implement for syncer - requirements: - [x] syncer must be able to detect if sequencer was malicious and hasn't included a forced tx - [x] fetched inclusion of the txs bytes within the block data - [x] if that happened, reject all future sequencer blocks - [x] eventually, become based and keep produce block - [x] tool for submitting forced txs in celestia easily -> evstack/ev-abci#295 - [x] make sure epochs are in sync between syncer and executor ---- for later, won't be included in this pr (ref #2797 (comment)) - [ ] improve offline capabilities (if sequencer goes offline, full node become fully based) - [ ] when sequencer comes back only, needs to fetch if any block was produced :/ --------- Co-authored-by: Marko <[email protected]>
8 tasks
Member
Author
|
This should be updated to latest main. The command should be more like evstack/ev-node#2888. |
github-merge-queue bot
pushed a commit
to evstack/ev-node
that referenced
this pull request
Dec 4, 2025
Add force inclusion command for evm app. Similar to evstack/ev-abci#295 ~~Blocked on #2797 --------- Co-authored-by: Marko <[email protected]>
julienrbrt
added a commit
to evstack/ev-node
that referenced
this pull request
Dec 4, 2025
Add force inclusion command for evm app. Similar to evstack/ev-abci#295 ~~Blocked on #2797 --------- Co-authored-by: Marko <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Command to use (and test) forced inclusion (cf evstack/ev-node#2797)