Try uv setup #652
Try uv setup #652
Conversation
ArBridgeman
requested a deployment
to
manual-approval
GitHub Actions
Waiting
| { name = "Nicola Coretti", email = "[email protected]" }, | ||
| { name = "Ariel Schulz", email = "[email protected]" }, | ||
| ] | ||
| requires-python = ">=3.10,<4.0" |
There was a problem hiding this comment.
✅ re-orders section, I think consistently - could check docu
| "infrastructure", | ||
| ] | ||
| dynamic = ["dependencies"] | ||
| dependencies = [ |
There was a problem hiding this comment.
✅ does correctly and orders
| "exasol", | ||
| "infrastructure", | ||
| ] | ||
| dynamic = ["dependencies"] |
There was a problem hiding this comment.
➖ needed to remove this manually, as it remains
| "twine>=6.1.0,<7", | ||
| ] | ||
|
|
||
| [project.urls] |
There was a problem hiding this comment.
originally this was incorrectly labeled, so it didn't get converted.
neither poetry nor uv were angry about that.
| Issues = "https://github.com/exasol/python-toolbox/issues" | ||
| Changelog = "https://exasol.github.io/python-toolbox/changelog.html" | ||
|
|
||
| [project.scripts] |
There was a problem hiding this comment.
✅ correctly converted & works in CLI (after creating new env)
| tbx = "exasol.toolbox.tools.tbx:CLI" | ||
| sphinx-multiversion = "exasol.toolbox.sphinx.multiversion:main" | ||
|
|
||
| # unused entry point as using project.scripts instead |
There was a problem hiding this comment.
➖ kept/added this and it should be manually removed
| # manually remove | ||
| #[project.entry-points] | ||
|
|
||
| [dependency-groups] |
There was a problem hiding this comment.
✅ did this correctly and ordered it
pyproject.toml
Outdated
| "cookiecutter>=2.6.0,<3", | ||
| ] | ||
|
|
||
| # Needed for poetry intsall to run again |
There was a problem hiding this comment.
➖ I don't think there's a way to preserve poetry too much, so this needed to be manually copied back over these two sections (see intermediate commits).
| sphinx-inline-tabs = "^2023.4.21" | ||
| sphinx-design = ">=0.5.0,<1" | ||
| sphinx-toolbox = "^4.0.0" | ||
| typer = { extras = ["all"], version = ">=0.7.0" } |
There was a problem hiding this comment.
✅ uv told us typer[all] isn't a thing, but ➖ we needed to manually do
ArBridgeman
force-pushed
the
try-uv-setup
branch
from
078a17f to
f5233d3
Compare
ArBridgeman
requested a deployment
to
manual-approval
GitHub Actions
Waiting
| sphinx-multiversion = 'exasol.toolbox.sphinx.multiversion:main' | ||
|
|
||
| # manually re-add as needed for code | ||
| [tool.poetry.requires-plugins] |
There was a problem hiding this comment.
➖ need to manually re-add
| "F", # Pyflakes rules (excluding F401) | ||
| "UP", # pyupgrade rules | ||
| "D", # Docstring rules | ||
| "E", # Syntax errors |
There was a problem hiding this comment.
Sometimes it removes comments. Here it kept them, but this would be something to watch out for.
| "cookiecutter>=2.6.0,<3", | ||
| ] | ||
|
|
||
| # Needed for poetry install to run again |
There was a problem hiding this comment.
➖ needed to override these two sections with what we had before
| { name = "Nicola Coretti", email = "[email protected]" }, | ||
| { name = "Ariel Schulz", email = "[email protected]" }, | ||
| ] | ||
| requires-python = ">=3.10,<4.0" |
There was a problem hiding this comment.
Note that this migration mostly works for PTB as most dependencies are main ones but would need to switch to Poetry 2.2.x or update PTB otherwise to handle dev dependencies moving to groups.
Checklist
Note: If any of the items in the checklist are not relevant to your PR, just check the box.
For any Pull Request
Is the following correct:
When Changes Were Made
Did you:
When Preparing a Release
Have you: