Added documentation for NextJS and SolidJS#2986
Added documentation for NextJS and SolidJS#2986Dryspell wants to merge 3 commits intoexcaliburjs:mainfrom
Conversation
|
@Dryspell Awesome! We actually need to keep docusaurus pinned at 3.0.0 because we have a specific patch for 3.0.0 at the moment. |
eonarheim
left a comment
There was a problem hiding this comment.
Switch docusaurus deps back to pinned 3.0.0, normally updating this would be okay but we have a 3.0.0 specific patch at the moment
|
@Dryspell I'm going to have some more JSX familiar peeps look at this too (since I'm not very familiar myself) |
|
A few thoughts:
My concern is if, for example, many people start using this |
So with regards to this, I agree for the most part but I also expect that without a way indicated to trigger react re-renders automatically / in a managed fashion, we might be getting a lot of questions about how to trigger React to rerender and this feels like a way to head those off. React won't trigger the rerenders as Excalibur values change and most React devs coming in to Excalibur without this info... well I expect they will either have to do the research and discovery that I did, give up, or ask the question. TBH I don't trust how much experience most React devs have, feels like a lot of new people coming into the space. Definitely am willing to do whatever you guys recommend though, I am but a lowly contributor :D |
This is what worries me because the devil truly is in the details there. We have had people who just need to throw in their Excalibur game into a NextJS site or whatever, so that could still be worth covering, but I'm not certain it's worth trying to maintain a post for every major framework. I kind of like the idea of having a post like you've written that's focused just on bridging communication between Excalibur and a modern framework (I'd pick 1, like Solid, because it at least comes with reactive state management out of the box) |
|
Maybe offer a warning in the docs page that updating UI elements every frame could have performance implications? I certainly understand the weirdness of coming to React and being like ok you're inventing a new signal here for what...? I certainly suspect there's a better way to implement the whole idea of this custom signal. Like perhaps using excalibur's |
|
@Dryspell I haven't forgotten about this! I'm slowly working down my list |
No worries! I've been on a long break from Excalibur taking a look at Unity ECS and understanding Websockets better, trying to see what it would be like to implement a request/response framework over websockets. Definitely let me know if you have other ideas or changes that you'd like me to make |
|
This PR hasn't had any recent activity lately and is being marked as stale automatically. |
|
A bit late to the party, but the Next docs are really written Dryspell! I do agree with @mattjennings regarding the amount of direction about bridging the two though.
I think the docs should go as far as (a). Which is approximately up to the (b) is more related to this section in the docs I believe. But even just within the React space, there are quite a few ways to glue the two together and its hard to prescribe the most idiomatic Excalibur + React patterns. Even just browsing through discussions and the Discord there are quite a few discussions on approach. A well written blog post, which covers the signals, render cycles, vdom, etc, would be amazing to see though. You could then really get into that nitty gritty |
|
This PR hasn't had any recent activity lately and is being marked as stale automatically. |
Created new documentation pages for NextJS and SolidJS and I updated the package JSON for docusaurus to be on the latest version. I also ran
npm updateandnpm audit fixwhich reflects the changes in the package lock.