Rewrote in Typescript and added support for HTMX Extensions #7
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I was trying to use this extension the other day, but was surprised that there was no support for type definitions, which was causing IDE errors. I've re-written the project in Typescript and added a build-step which generates
.js,.mjs. and.d.tsfiles, as well as added an.npmignorefile which means that published files should only include the compiled files as well as thepackage.jsonand readme files.The second feature I thought would be cool was adding support for HTMX Extensions. With this update, extensions can be added and globally registered by the integration. I've tested it with the Response Targets Extension, but the process should match for all extensions. I added JSDoc comments explaining how to implement these changes, but updates to the readme/example might be in order as well.
I didn't have much time to put into this, but if you need changes made before merging, I'll be happy to make those in the coming weeks as I find time.